Skip to content

Adding proximity-chat to Runescape#11729

Open
DMoneigh wants to merge 23 commits into
runelite:masterfrom
DMoneigh:master
Open

Adding proximity-chat to Runescape#11729
DMoneigh wants to merge 23 commits into
runelite:masterfrom
DMoneigh:master

Conversation

@DMoneigh
Copy link
Copy Markdown

@DMoneigh DMoneigh commented May 1, 2026

This plugin allows users to communicate via proximity voice chat. Its in the Alpha stage now so we can see what the server load is like. We will more features once we get feedback from the community.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 1, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 1, 2026

Feedback:

  • javax.sound.sampled.Mixer.getTargetLineInfo: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.close: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.TargetDataLine.start: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Mixer$Info: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Mixer$Info.getVersion: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.TargetDataLine.close: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.TargetDataLine.open: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Mixer$Info.getName: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Line: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.DataLine$Info.<init>: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Mixer$Info.getDescription: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioSystem.getMixer: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioFormat: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Mixer$Info.toString: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.TargetDataLine.read: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.start: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine.open: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • java.lang.Exception.printStackTrace: system i/o, use a logger instead.
  • javax.sound.sampled.DataLine$Info: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioSystem: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Line$Info: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.SourceDataLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Mixer.getLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • java.lang.System.out: system i/o, use a logger instead.
  • javax.sound.sampled.SourceDataLine.write: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioFormat.<init>: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.TargetDataLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.DataLine: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Mixer$Info.getVendor: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.AudioSystem.getMixerInfo: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Mixer.getSourceLineInfo: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.Mixer: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • javax.sound.sampled.LineUnavailableException: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 16, 2026

At ~25k lines of code this submission is unlikely to ever be reviewed by the volunteers that work this queue. I would encourage you to proceed with a smaller initial release (basically under 10k lines or less) and add new features over time.

@riktenx riktenx closed this May 16, 2026
@riktenx riktenx reopened this May 16, 2026
@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 17, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 19, 2026
@DMoneigh
Copy link
Copy Markdown
Author

DMoneigh commented May 19, 2026

Hey @riktenx, I removed the 24k lines of code. It was just the pure Java Opus library. I added it as a gradle dependency found here - https://github.com/lostromb/concentus/tree/master/Java/Concentus

dependencies { implementation 'io.github.jaredmdobson:concentus:1.0.2' }

Now I am getting this error - https://github.com/runelite/plugin-hub/actions/runs/26080308439/job/76680179226?pr=11729

@Alexsuperfly
Copy link
Copy Markdown
Contributor

you need build=gradle in runelite-plugin.properties to use your own build.gradle, the standard build uses the default build.gradle template when building for the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants