Skip to content

fix(webapp): shared-page inline code reads as code in dark mode (BEA-90) #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssowonny merged 1 commit into from
Aug 10, 2026
+15 −1
Merged

fix(webapp): shared-page inline code reads as code in dark mode (BEA-90) #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion internal/webapp/shares.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,12 +543,17 @@ footer.bdrive a{color:inherit}
/* Dark theme LAST: these rules sit at the same specificity as the light ones
above, so source order is the whole fix — a dark block placed earlier loses
to every light rule that follows it. Values are the hub's @theme tokens
(frontend/src/tw.css), never hand-picked, so the two surfaces agree. */
(frontend/src/tw.css), never hand-picked, so the two surfaces agree.
Inline code carries its own tint and edge so a chip reads as code and not
as prose; the edge is an inset shadow rather than a border because a border
would change the chip's box metrics and light mode has to stay untouched. */
@media (prefers-color-scheme: dark){
body{background:#0a0b0d;color:#eef0f3}
a{color:#ffcf85}
h1,h2,h3{color:#eef0f3}
pre,code{background:#15171b}
code{color:#e4d9c4;box-shadow:inset 0 0 0 1px rgba(255,255,255,.07)}
pre code{color:inherit;box-shadow:none}
blockquote{border-left-color:rgba(255,255,255,.07);color:#9aa0a9}
td,th{border-color:rgba(255,255,255,.07)}
table.frontmatter{background:#15171b;color:#9aa0a9}
Expand Down
9 changes: 9 additions & 0 deletions internal/webapp/shares_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,15 @@ func TestShareDarkThemeIsLast(t *testing.T) {
if strings.Contains(body, "#c6cbd3") || strings.Contains(body, "#3a3a44") {
t.Error("ad-hoc dark greys survived; use the tw.css tokens")
}
// A code chip has to read as code: its own colour, not the body's, plus an
// edge to give it shape against a background only a shade off the page.
if !strings.Contains(block, "code{color:#e4d9c4;box-shadow:inset 0 0 0 1px") {
t.Error("dark inline code must have its own colour and edge, else a chip reads as prose")
}
// ...and a fenced block stays one slab rather than a row of bordered chips.
if !strings.Contains(block, "pre code{color:inherit;box-shadow:none}") {
t.Error("dark pre code must reset the inline chip's colour and edge")
}
}

func jsonReq(t *testing.T, method, url string, body any) *http.Request {
Expand Down
Loading