Skip to content

Support block in CSV::Row#to_h #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 13 commits into from
May 3, 2026
+49 −2
Merged

Support block in CSV::Row#to_h #356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
121991c
Support block in CSV::Row#to_h
tsymbalenkovlad Apr 29, 2026
0707869
Simplify block_given? case based on @kou feedback
tsymbalenkovlad Apr 30, 2026
a11c20f
Separate block test case
tsymbalenkovlad Apr 30, 2026
7dbaa45
Get value from self
tsymbalenkovlad Apr 30, 2026
8257d8e
Fix formatting
tsymbalenkovlad Apr 30, 2026
a01ef69
Improve condition and test, add documentation
tsymbalenkovlad Apr 30, 2026
58388dc
Merge branch 'main' of github.com:tsymbalenkovlad/csv
tsymbalenkovlad Apr 30, 2026
1298ed9
Add call-seq doc
tsymbalenkovlad Apr 30, 2026
f1bbb99
Handle repeated headers in block, validate block result type
tsymbalenkovlad May 1, 2026
ff84e8a
Improve validation of block result
tsymbalenkovlad May 1, 2026
a8797a1
Fix class in error and doc
tsymbalenkovlad May 2, 2026
929c20d
Skip duplicate transformed key earlier, add spec for value transforma…
tsymbalenkovlad May 2, 2026
bc0fe31
Separate tests
tsymbalenkovlad May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/csv/row.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,8 +652,13 @@ def ==(other)
# row.to_h # => {"Name"=>"Foo"}
def to_h
hash = {}
each do |key, _value|
hash[key] = self[key] unless hash.key?(key)
each do |key, value|
new_key, new_value = if block_given?
yield(key, value)
else
[key, value]

@kou kou Apr 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to create a needless temporary Array.

Could you use

if block_given?
  each do |key, value|
    key, value = yield(key, value)
    # ...
  end
else
  each do |key, value|
    # ...
  end
end

or

each do |key, value|
  key, value = yield(key, value) if block_given?
  # ...
end

?

@tsymbalenkovlad tsymbalenkovlad Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a good one

end
Comment on lines +677 to +679
hash[new_key] = new_value unless hash.key?(new_key)
end
hash
end
Expand Down
3 changes: 3 additions & 0 deletions test/csv/test_row.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,9 @@ def test_to_hash
assert_predicate(string_key, :frozen?)
assert_same(string_key, @row.headers[h])
end
row2 = CSV::Row.new(%w{A B C}, [1, 2, 3])
hash2 = row2.to_hash { |k, v| [k, v ** 2] }
assert_equal({"A" => 1, "B" => 4, "C" => 9}, hash2)

@kou kou Apr 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a separated test?

end

def test_to_csv
Expand Down
Loading