Skip to content

Fix relative IRIs containing a forward slash before a colon being incorrectly treated as absolute#28

Merged
rubensworks merged 3 commits into
masterfrom
copilot/fix-relative-to-absolute-iri-issue
Mar 5, 2026
Merged

Fix relative IRIs containing a forward slash before a colon being incorrectly treated as absolute#28
rubensworks merged 3 commits into
masterfrom
copilot/fix-relative-to-absolute-iri-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 5, 2026

  • Fix lib/Resolve.ts: when checking if an IRI is absolute (has a colon), also verify the colon appears before any forward slash (per RFC 3986, a URI scheme cannot contain /)
  • Add unit tests for relative IRIs where a / appears before the : (e.g., x/y:z, x/y:z:w)
  • Remove package-lock.json and revert yarn.lock to original state
  • All tests pass with 100% coverage

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue in relative-to-absolute-iri function Fix relative IRIs containing a forward slash before a colon being incorrectly treated as absolute Mar 5, 2026
Copy link
Copy Markdown
Owner

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the package-lock.json, and undo the changes to yarn.lock

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 5, 2026

Please remove the package-lock.json, and undo the changes to yarn.lock

Done in 1bf01a0 — removed package-lock.json (and added it to .gitignore) and reverted yarn.lock to its original state.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 22725799166

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 20221587276: 0.0%
Covered Lines: 102
Relevant Lines: 102

💛 - Coveralls

@rubensworks rubensworks marked this pull request as ready for review March 5, 2026 15:50
@rubensworks rubensworks merged commit 0bd83dc into master Mar 5, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants