Skip to content

fix(install): verify sha256 checksum of downloaded release tarball #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
if414013 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(install): verify sha256 checksum of downloaded release tarball #1395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,17 @@ error() {
exit 1
}

# Compute sha256 of a file, portable across GNU (sha256sum) and BSD/macOS (shasum).
sha256_of() {
if command -v sha256sum >/dev/null 2>&1; then
sha256sum "$1" | awk '{print $1}'
elif command -v shasum >/dev/null 2>&1; then
shasum -a 256 "$1" | awk '{print $1}'
else
error "No sha256 tool found on system (need sha256sum or shasum)"
fi
}

# Detect OS
detect_os() {
case "$(uname -s)" in
Expand Down Expand Up @@ -83,6 +94,26 @@ install() {
error "Failed to download binary"
fi

# Verify the downloaded tarball against the release's published checksums.
# Without this check, a tampered release asset or a MITM on the download
# would be installed silently.
CHECKSUMS_URL="https://github.com/${REPO}/releases/download/${VERSION}/checksums.txt"
CHECKSUMS_FILE="${TEMP_DIR}/checksums.txt"
info "Downloading checksums..."
if ! curl -fsSL "$CHECKSUMS_URL" -o "$CHECKSUMS_FILE"; then
error "Failed to download checksums.txt for ${VERSION}"
fi
ARCHIVE_NAME="${BINARY_NAME}-${TARGET}.tar.gz"
EXPECTED=$(awk -v f="$ARCHIVE_NAME" '{sub(/^\*/, "", $2); if ($2 == f) print $1}' "$CHECKSUMS_FILE")
if [ -z "$EXPECTED" ]; then
error "No checksum found for ${ARCHIVE_NAME} in checksums.txt"
fi
ACTUAL=$(sha256_of "$ARCHIVE")
if [ "$EXPECTED" != "$ACTUAL" ]; then
error "Checksum mismatch for ${ARCHIVE_NAME}: expected ${EXPECTED}, got ${ACTUAL}"
fi
info "Checksum verified (sha256)"

info "Extracting..."
tar -xzf "$ARCHIVE" -C "$TEMP_DIR"

Expand Down