You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oh! also note that a coverage failure will NOT cause a build failure. I suspect you got an error on that build that "passed". Can you check the log and see what happened?
Activity
florence commentedon Sep 30, 2015
It looks instructions in the README are bogus.
While I get that fixed: What you want is to add
cover-coverallsto your build-deps, the use a travis.yaml file like in https://github.com/florence/pop-pl/blob/master/.travis.yml .Also, step 6 looks like a bug in the package system I thought I had fixed.... What OS are you on, and what version of racket are you running?
Fixing README for Issue #5
florence commentedon Sep 30, 2015
Oh! also note that a coverage failure will NOT cause a build failure. I suspect you got an error on that build that "passed". Can you check the log and see what happened?
bennn commentedon Sep 30, 2015
OSX 10.7.5, Racket v6.9.700.17
Yes my Travis builds all pass. Steps 4,5,6 were run locally on my own command line -- I just wanted to see if it would work outside of Travis.
New travis.yml
florence commentedon Sep 30, 2015
The call to coveralls may have failed even if the travis builds passed. Can you inspect the logs for an error?
What racket commit are you on/how recent is your build? The fix for the pkg bug was only put in last week.
bennn commentedon Sep 30, 2015
Success! I do have coverage reports with the POP-PL travis file.
My Racket is September 18, commit a9015e5484865157f.
The calls to coveralls were failing in Travis when called "after success".
florence commentedon Sep 30, 2015
Wohoo!
@bennn yeah, if you grab a more recent racket version things should work locally.
@rpless do the changes I made to the readme look good enough to close this?