add "--log-level" option for "ros2 component load"#1212
Open
penww wants to merge 1 commit into
Open
Conversation
penww
force-pushed
the
rolling
branch
2 times, most recently
from
7971d62 to
7ee6285
Compare
|
@fujitatomoya can you have a look at this ? |
fujitatomoya
requested changes
Apr 23, 2026
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
can we use the following instead?
this should reduce the implementation and maintenance cost.
although ros2component does not have much unit tests, test that makes sure logging level is actually applied would be nice to have.
Author
|
Thanks @fujitatomoya for review. will update. |
Signed-off-by: Peng Wang <penwang@qti.qualcomm.com>
Author
|
Updated, please help to review again, thank you very much @fujitatomoya |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes (ros2/rclcpp#3091)
Support set component level
log-level:Is this user-facing behavior change?
No, the additional log level falls back to the current behavior.
Did you use Generative AI?
Partially with Claude Sonnet 4.6
Additional Information
Related PR: ros2/rclcpp#3092