Use zenoh-cpp 481b71b fixing build with MSVC 2022 in C++20 mode#969
Merged
Conversation
Contributor
Author
|
Pulls: #969
|
|
rmw_zenoh_cpp is passing now. the current compile error is due to something else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The upgrade to MSVC 19.44 (VS 2022 17.14, 14.44.35207) and the change of the minimum c++ version for all ROS packages to c++20 and C17 made
zenoh-cppbuild to fail when buildingzenoh_cpp_vendor.It was fixed in
zenoh-cppby eclipse-zenoh/zenoh-cpp#776 and eclipse-zenoh/zenoh-cpp#778.This PR bump the
zenoh-cppcommit id to eclipse-zenoh/zenoh-cpp@481b71b to include those 2 fixes.Is this user-facing behavior change?
No
Did you use Generative AI?
No