Refactor: base clock#1627
Conversation
Signed-off-by: Nadav Elkabets <[email protected]>
Signed-off-by: Nadav Elkabets <[email protected]>
…Clock Signed-off-by: Nadav Elkabets <[email protected]>
Signed-off-by: Nadav Elkabets <[email protected]>
Signed-off-by: Nadav Elkabets <[email protected]>
|
@nadavelkabets just a note (from @InvincibleRMC) that resolute (26.04) is going to be using Python 3.14, which does introduce some AsyncIO API changes. You may want to pre-test what you have here for when we make the jump later this month. |
mjcarroll
left a comment
There was a problem hiding this comment.
Approve with a single nit and green CI.
Overall a solid refactor.
I checked the 3.13 and 3.14 changelogs - 3.13 adds keyword argument passing to the task constructor and some new util functions, and 3.14 adds task introspection. Neither affects us. |
Co-authored-by: Michael Carroll <[email protected]> Signed-off-by: Nadav Elkabets <[email protected]>
Signed-off-by: Nadav Elkabets <[email protected]>
eeb3d9e to
69a490e
Compare
Signed-off-by: Nadav Elkabets <[email protected]>
|
@mjcarroll could you run CI again please? |
|
Pulls: #1627 |
skyegalaxy
left a comment
There was a problem hiding this comment.
lgtm with green CI. looks like a solid refactor!
Part of #1620
Changes
sleep_for()andsleep_until()methodsisinstance()Notes
ros_time_is_active()andset_ros_time_override(). Similar to rclcpp, RCLError is raised if the clock is not a ROS_TIME clockClock.__new__- surprising behavior that silently returned a ROSClock instance when Clock was initialized withclock_type=ROS_TIME