Skip to content

Add pytest-asyncio dependency#868

Merged
christophebedard merged 1 commit into
ros2:masterfrom
nadavelkabets:feature/add-pytest-asyncio-dep
Apr 21, 2026
Merged

Add pytest-asyncio dependency#868
christophebedard merged 1 commit into
ros2:masterfrom
nadavelkabets:feature/add-pytest-asyncio-dep

Conversation

@nadavelkabets
Copy link
Copy Markdown
Contributor

Required for ros2/rclpy#1620

@christophebedard
Copy link
Copy Markdown
Member

FYI I pushed your branch to this repo (https://github.com/ros2/ci/tree/feature/add-pytest-asyncio-dep) so that we can use/test it in a ci.ros2.org job. If you modify your branch here, we need to re-push it if we want to re-test

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Apr 20, 2026

CI for ros2/rclpy#1620 with:

  1. Linux dep from Add pytest-asyncio dependency #868 (using https://github.com/ros2/ci/tree/feature/add-pytest-asyncio-dep)
  2. Windows dep from Feature: add pytest-asyncio dependency ros2#1818
  3. RHEL 10 (not the current default, RHEL 9)
  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Signed-off-by: Nadav Elkabets <[email protected]>
@christophebedard christophebedard force-pushed the feature/add-pytest-asyncio-dep branch from aa1203d to 9639851 Compare April 20, 2026 18:17
@christophebedard
Copy link
Copy Markdown
Member

I rebased your branch (+ the copy of your branch I pushed to this repo) onto master since #869 was merged.

@christophebedard
Copy link
Copy Markdown
Member

@cottsay this should be fairly safe to merge before ros2/rclpy#1620 is merged. python3-pytest-asyncio is in Ubuntu Jammy and later (https://packages.ubuntu.com/jammy/python3-pytest-asyncio) as well as RHEL 8 and later (https://pkgs.org/search/?q=python3-pytest-asyncio)

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Apr 20, 2026

CI for ros2/rclpy#1620 for rclpy and above with:

  1. Linux dep from Add pytest-asyncio dependency #868 (using https://github.com/ros2/ci/tree/feature/add-pytest-asyncio-dep)
  2. Windows dep from Feature: add pytest-asyncio dependency ros2#1818
  3. (RHEL 9 like the current default, not RHEL 10)
  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard christophebedard merged commit 26f54fd into ros2:master Apr 21, 2026
2 checks passed
@christophebedard
Copy link
Copy Markdown
Member

I'll delete https://github.com/ros2/ci/tree/feature/add-pytest-asyncio-dep once all CI jobs I've triggered with it have completed (in case they end up flaking and getting retried)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants