Skip to content

OMPL and Qt API update, bump cmake minimum version requirement#6136

Draft
mini-1235 wants to merge 2 commits into
ros-navigation:mainfrom
mini-1235:lyrical/sync
Draft

OMPL and Qt API update, bump cmake minimum version requirement#6136
mini-1235 wants to merge 2 commits into
ros-navigation:mainfrom
mini-1235:lyrical/sync

Conversation

@mini-1235
Copy link
Copy Markdown
Collaborator


Basic Info

Info Please fill out this column
Ticket(s) this addresses Lyrical Sync
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

mini-1235 added 2 commits May 9, 2026 19:32
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mini-1235
Copy link
Copy Markdown
Collaborator Author

mini-1235 commented May 9, 2026

I figured out that the EventsExecutor wasn't included in the last rolling sync, but we do have it in Lyrical, so it seems easier for me to test it in Lyrical :)

This PR fixes all the compile errors but is not ready to review/merge, I am opening as draft to check the backward compatibility for Jazzy/Kilted. It also depends on ros2/message_filters#292, ros/rosdistro#51321, BehaviorTree/BehaviorTree.CPP#1139, and an upstream OMPL sync, we should probably merge this after we migrate to Ubuntu 26.04 (most fixes here are related to 26.04 using g++15)

@mini-1235 mini-1235 marked this pull request as draft May 9, 2026 19:41
* @param radius New circle radius to update polygon
*/
void updatePolygon(double radius);
void updatePolygonFromRadius(double radius);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain


// Check if it is not same with the current one
if (goal_.path != new_path && new_path != nav_msgs::msg::Path()) {
if (goal_.path != new_path && !new_path.poses.empty()) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain

tf2_ros::Buffer & tf_;
std::string robot_base_frame_;
double transform_tolerance_;
bool footprint_received_{false};
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain

}

virtual bool rotateToObject(geometry_msgs::msg::PoseStamped &)
virtual bool rotateToObject(geometry_msgs::msg::PoseStamped &, const std::string &)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain

EXPECT_EQ(a.asWrapped<bool>(bool_p), false);
EXPECT_EQ(a.asWrapped<std::string>(string_p), std::string("hello"));

EXPECT_EQ(a.asWrapped<std::vector<int64_t>>(intv_p)[0], 1);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain

* @return The number of direction changes in the path
*/
int countDirectionChanges(const ompl::base::ReedsSheppStateSpace::ReedsSheppPath & path);
int countDirectionChanges(const ompl::base::ReedsSheppStateSpace::PathType & path);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiling fails?

// Connect buttons with functions
QObject::connect(
use_dock_id_checkbox_, &QCheckBox::stateChanged, this, &DockingPanel::dockIdCheckbox);
use_dock_id_checkbox_, &QCheckBox::checkStateChanged, this, &DockingPanel::dockIdCheckbox);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain

QObject::connect(
store_initial_pose_checkbox_,
&QCheckBox::stateChanged,
&QCheckBox::checkStateChanged,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants