-
Notifications
You must be signed in to change notification settings - Fork 3
Covers the file creation events by tests #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
roma-glushko
wants to merge
5
commits into
main
Choose a base branch
from
covered-filesystem-events-by-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [pytest] | ||
| asyncio_mode = auto | ||
| xfail_strict = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import asyncio | ||
| from contextlib import asynccontextmanager | ||
|
|
||
| import async_timeout | ||
| from typing import AsyncContextManager, AsyncGenerator, Self | ||
|
|
||
| from notifykit import NotifierT, Event | ||
|
|
||
|
|
||
| class EventCollector: | ||
| def __init__(self, ): | ||
| self._events: list[Event] = [] | ||
| self._notifier_task: asyncio.Task | None = None | ||
|
|
||
| self._waiters: set[tuple[int, asyncio.Event]] = set() | ||
|
|
||
| @property | ||
| def events(self) -> list[Event]: | ||
| return self._events | ||
|
|
||
| @asynccontextmanager | ||
| async def collect(self, notifier: NotifierT) -> AsyncGenerator[Self, None]: | ||
| if self._notifier_task is not None: | ||
| raise RuntimeError("EventCollector is already running.") | ||
|
|
||
| self._notifier_task = asyncio.create_task(self._collect_events(notifier)) | ||
|
|
||
| yield self | ||
|
|
||
| notifier.stop() | ||
|
|
||
| if self._notifier_task: | ||
| self._notifier_task.cancel() | ||
| try: | ||
| await self._notifier_task | ||
| except asyncio.CancelledError: | ||
| pass | ||
| self._notifier_task = None | ||
|
|
||
| async def wait_for_events(self, items: int, timeout: float = 2) -> None: | ||
| if items <= len(self._events): | ||
| return | ||
|
|
||
| waiter = asyncio.Event() | ||
| waiter_id = (items, waiter) | ||
|
|
||
| self._waiters.add(waiter_id) | ||
|
|
||
| async with async_timeout.timeout(timeout): | ||
| await waiter.wait() | ||
|
|
||
| self._waiters.remove(waiter_id) | ||
|
|
||
| async def _collect_events(self, notifier: NotifierT) -> None: | ||
| async for event in notifier: | ||
| self._events.extend(event) | ||
| self._wakeup_waiters() | ||
|
|
||
| def _wakeup_waiters(self) -> None: | ||
| for items, event in self._waiters: | ||
| if items <= len(self._events): | ||
| event.set() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import asyncio | ||
| import tempfile | ||
| from pathlib import Path | ||
|
|
||
| from notifykit import Notifier, NotifierT | ||
| from tests.conftest import EventCollector | ||
|
|
||
|
|
||
| async def test__events__create_file() -> None: | ||
| files_to_create = 3 | ||
| expected_events = files_to_create * 3 # each file triggers 3 events: Create, ModifyMetadata, ModifyData | ||
| tmp_dir = Path(tempfile.mkdtemp()) | ||
|
|
||
| await asyncio.sleep(0.1) # avoid catching directory creation event | ||
|
|
||
| notifier: NotifierT = Notifier(debounce_ms=100, tick_ms=10, debug=False) | ||
| await notifier.watch([tmp_dir]) | ||
|
|
||
| collector = EventCollector() | ||
|
|
||
| async with collector.collect(notifier) as c: | ||
| expected_paths = [] | ||
|
|
||
| for idx in range(files_to_create): | ||
| file_path = tmp_dir / f'lorem_{idx}.txt' | ||
| file_path.write_text("new lorem ipsum") | ||
|
|
||
| expected_paths.append(str(file_path)) | ||
|
|
||
| await c.wait_for_events(expected_events, timeout=3) | ||
|
|
||
| assert len(collector.events) == expected_events, collector.events |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary trailing comma and space in the
__init__parameter list. Should bedef __init__(self):.