Skip to content

Security enhancements - #155

Merged
TwitchBronBron merged 1 commit into
masterfrom
fix/npm-audit-vulnerabilities
Aug 6, 2026
Merged

Security enhancements#155
TwitchBronBron merged 1 commit into
masterfrom
fix/npm-audit-vulnerabilities

Conversation

@TwitchBronBron

Copy link
Copy Markdown
Member

Summary

  • `npm run audit` was reporting 6 vulnerabilities: brace-expansion, js-yaml (high), @babel/core (low), and the already-allowlisted uuid/istanbul-lib-processinfo/nyc chain (moderate)
  • brace-expansion/js-yaml/@babel/core are pulled in exclusively through eslint/mocha/nyc devDependencies, never shipped — pinned via the existing `overrides` block (same pattern already used for serialize-javascript)
  • `uuid` stays untouched and allowlisted in audit-ci.jsonc: `istanbul-lib-processinfo@2.0.2` does `require('uuid/v4')`, a deep subpath import that uuid's `exports` map has never supported past uuid@8. Confirmed by attempting the override — it throws `ERR_PACKAGE_PATH_NOT_EXPORTED` at test time. The vulnerable v3/v5/v6 buffer-bounds path is unreachable regardless since istanbul-lib-processinfo only calls v4()

Test plan

  • `npm run audit` passes
  • `npm run build` passes
  • `npm run lint` passes
  • `npm run test` passes (285 passing, 100% coverage maintained)

🤖 Generated with Claude Code

brace-expansion, js-yaml, and @babel/core are pulled in exclusively
through eslint/mocha/nyc (dev tooling), never shipped. No non-major
version resolves them through normal resolution, so pin patched
versions via overrides, same pattern already used for
serialize-javascript.

uuid stays untouched and allowlisted in audit-ci.jsonc:
istanbul-lib-processinfo@2.0.2 does `require('uuid/v4')`, a deep
subpath import that uuid's `exports` map has never supported past
uuid@8 (confirmed: attempting the override throws
ERR_PACKAGE_PATH_NOT_EXPORTED at test time). No non-major nyc bump
resolves this; the vulnerable v3/v5/v6 buffer-bounds path is
unreachable regardless since istanbul-lib-processinfo only calls v4().

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@TwitchBronBron TwitchBronBron added the Security enhancements Security-related dependency/vulnerability fixes label Aug 6, 2026
@TwitchBronBron TwitchBronBron changed the title Fix devDependency-only npm audit vulnerabilities via overrides Security enhancements Aug 6, 2026
@TwitchBronBron
TwitchBronBron merged commit 95057d8 into master Aug 6, 2026
10 checks passed
@TwitchBronBron
TwitchBronBron deleted the fix/npm-audit-vulnerabilities branch August 6, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Security enhancements Security-related dependency/vulnerability fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant