Skip to content

fix: evicted observations leave ghost entries in search indexes #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fix2015 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

fix: evicted observations leave ghost entries in search indexes #1005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/functions/evict.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { KV } from "../state/schema.js";
import { StateKV } from "../state/kv.js";
import { recordAudit } from "./audit.js";
import { deleteAccessLog } from "./access-tracker.js";
import { getSearchIndex, vectorIndexRemove, flushIndexSave } from "./search.js";
import { logger } from "../logger.js";

interface EvictionConfig {
Expand Down Expand Up @@ -212,6 +213,8 @@ export function registerEvictFunction(sdk: ISdk, kv: StateKV): void {
});
continue;
}
getSearchIndex().remove(o.id);
vectorIndexRemove(o.id);
if (o.imageData) await decrementImageRef(kv, sdk, o.imageData);
if (o.imageRef && o.imageRef !== o.imageData) await decrementImageRef(kv, sdk, o.imageRef);
await recordAudit(kv, "delete", "mem::evict", [o.id], {
Expand Down Expand Up @@ -255,6 +258,8 @@ export function registerEvictFunction(sdk: ISdk, kv: StateKV): void {
});
continue;
}
getSearchIndex().remove(o.id);
vectorIndexRemove(o.id);
if (o.imageData) await decrementImageRef(kv, sdk, o.imageData);
if (o.imageRef && o.imageRef !== o.imageData) await decrementImageRef(kv, sdk, o.imageRef);
await recordAudit(kv, "delete", "mem::evict", [o.id], {
Expand Down Expand Up @@ -291,6 +296,8 @@ export function registerEvictFunction(sdk: ISdk, kv: StateKV): void {
});
continue;
}
getSearchIndex().remove(mem.id);
vectorIndexRemove(mem.id);
if (mem.imageRef) {
await decrementImageRef(kv, sdk, mem.imageRef);
}
Expand Down Expand Up @@ -326,6 +333,8 @@ export function registerEvictFunction(sdk: ISdk, kv: StateKV): void {
});
continue;
}
getSearchIndex().remove(mem.id);
vectorIndexRemove(mem.id);
if (mem.imageRef) {
await decrementImageRef(kv, sdk, mem.imageRef);
}
Expand All @@ -340,6 +349,10 @@ export function registerEvictFunction(sdk: ISdk, kv: StateKV): void {
}
}

if (!dryRun) {
await flushIndexSave();
}

logger.info("Eviction complete", { stats });
return stats;
},
Expand Down