Repository navigation
fix(body): "servos off" cuts the PWM signal — they really go limp - #79
Merged
Merged
Conversation
The robot HAT's MCU keeps sending the last pulse after the SDK stops writing angles, so deep sleep was a flag only: a sleeping dog held every joint under load, ran warm, and hummed against the hand holding it even with all Nox services stopped. Deep sleep, the sleep command, the emergency stop and the service shutdown now lie down and then write pulse width 0 on every servo; the next angle engages them again. Verified on the dog: 12 released, servos silent, legs move freely. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d servos sleep again - An emergency stop sent by the behavior engine (internal) set the sleeping flag that only external activity clears; its head moves were refused. It stays "resting" now and the watchdog sleeps it. - A move after release engages servos again: back to "resting", so the watchdog releases them once more. - Settle 0.3 s after the queue drains before releasing. - tests/conftest.py: quiet hours off in tests — engine tests failed at night. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field report: the servos hummed and pushed against Rocky's hand, even with nox-body, nox-bridge and nox-voice all stopped. The dog also got warm.
Cause: The robot HAT's MCU keeps sending the last PWM pulse after the SDK stops writing angles. The daemon's "deep sleep (servos off)" only set a flag, so every joint stayed under load.
Fix: New
_release_servos(). It waits for queued frames (for example thelie) and then writespulse_width(0)to every servo in legs, head and tail. It is called in four places:sleepemergency_stopThe dog always lies down first. The next angle the SDK writes re-engages the servos automatically.
Verified on the dog: started the daemon, sent
sleep, gotservos_released: 12. The servos went silent, the legs could be moved by hand, and no humming came back after 30 s.3 source-level tests (the daemon needs the SDK); 720 tests pass.
🤖 Generated with Claude Code