Repository navigation
fix(behavior): the dog never sets off on patrol by itself - #76
Merged
Merged
Conversation
A bored or curious mood started a patrol unattended — in the field with the
charging cables still plugged in — and /behavior/stop held only until the
next bridge restart. Mood-driven patrol is now opt-in (NOX_AUTO_PATROL=1);
POST /behavior/start {"state": "patrol"} still walks.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The main loop restored a forced patrol two seconds after anything took the dog out of it (stuck, touched, a person seen), so one request meant walking indefinitely. Forced rest/idle are still restored. Docs follow (review). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field report from Nox: the dog patrolled on its own with the cables still plugged in.
/behavior/stopalone did not keep it still; only the emergency stop plus sleep did.Cause:
_patrol_enabled = Truewas hardcoded. Two mood paths started a patrol: boredom in_tick_idle, andsuggest_state()for bored or curious.Fix:
_request_transitionrefuses a PATROL that the dog chose itself unlessNOX_AUTO_PATROL=1.force_state(from/behavior/start) is unaffected.🤖 Generated with Claude Code