possibility to get currents via status samples - #30
Open
dettmann wants to merge 1 commit into
Open
Conversation
Member
|
I think writing the current in a defined field of a JointState is a bad idea The components evaluating the current might later be confused with the one evaluating torques. So I think the best way would be to extend the JointState.hpp from base::types to also support currents. |
Author
|
You're right. I also thought of this. But I don't want to live with a patched base/type for longer time ;) (especially not when using the debian packages) If we change the JointState then we need to add also a reference position field (in mars, the raw field is used, which is also already a misuse) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need the currents from simulation as from the real robot, which is also sending currents instead of torques. The usage of the current output port not good, since it causes lot's of sim dependencies when utilized in another component.
I'm not sure, if this is the best way. Alternatively, one could use a base/types port for the currents or even a second base::samples:joints port (one filled with torques and one filled with currents)?
By the way, my editor removed all spaces causing many diffs. If desired, I could generate another commit just with the actual changes.