build: Fix rules_cc passing a removed flag to MSVC - #50
Merged
Conversation
Passing `/DEBUG:FASTLINK` to VS2026 emits a warning which is treated as
an error due to us building w/ `--features=treat_warnings_as_errors`.
LINK : warning LNK4315: /DEBUG:FASTLINK is no longer supported.
Using /DEBUG:FULL instead. Use a VS 2022 toolchain to continue
building with /DEBUG:FASTLINK
robinlinden
force-pushed
the
build-fix-vs2026
branch
from
July 18, 2026 12:27
dfc07fe to
9f82318
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
/DEBUG:FASTLINKto VS2026 emits a warning which is treated asan error due to us building w/
--features=treat_warnings_as_errors.