starlark: Treat newlines as tokens - #46
Merged
Merged
Conversation
This helps break up statements and fixes cases like
foo = bar
[2]
that previously would be parsed as `foo = bar[2]`.
The grammar reference says that newlines are only allowed around
statements, but that's definitely not the case. Our implementation is a
lot stricter about this than Bazel, but it handles everything we use in
this repo.
GrayHatter
reviewed
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps break up statements and fixes cases like
that previously would be parsed as
foo = bar[2].The grammar reference says that newlines are only allowed around statements, but that's definitely not the case. Our implementation is a lot stricter about this than Bazel, but it handles everything we use in this repo.