spec: roll up to Agent CLI Guidelines v0.4.0#1
Merged
Conversation
- Add machine-readable conformance block to `schema --json`
({spec, version, level}) backed by a new version.Spec = "0.4.0" const.
- Add `version --check` (GitHub Releases, 3s timeout, fail-silent) plus
Latest/UpdateAvailable/UpgradeHint helpers, mirroring the factory Go template.
- Add the starlight-llms-txt plugin to the docs site so /llms.txt,
/llms-full.txt, and /llms-small.txt are generated.
- Pin README conformance to v0.4.0 Full (badge + prose statement).
- Regenerate schema golden snapshot for the new flag + conformance block.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012UFrhC6bXVpoiiL3yhj2HH
There was a problem hiding this comment.
Pull request overview
Rolls vabc forward to Agent CLI Guidelines v0.4.0 (targeting Full conformance) by adding a machine-verifiable conformance block to schema --json, implementing version --check (pull-based, fail-silent), and updating the docs site to generate /llms*.txt.
Changes:
- Add
conformancemetadata toschema --jsonand regenerate the schema golden snapshot. - Add
version --checksupport with GitHub Releases lookup helpers ininternal/version. - Add the
starlight-llms-txtplugin to the Astro/Starlight docs site and lockfile.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| site/pnpm-lock.yaml | Locks new starlight-llms-txt dependency and its transitive tree. |
| site/package.json | Adds starlight-llms-txt dependency for docs-site /llms*.txt generation. |
| site/astro.config.mjs | Registers starlight-llms-txt as a Starlight plugin. |
| README.md | Documents v0.4.0 Full conformance claim and how to verify via schema --json. |
| internal/version/version.go | Adds spec constant + GitHub Releases “latest” lookup and update helpers for version --check. |
| internal/cli/testdata/schema.golden.json | Updates contract snapshot for new --check flag and conformance block. |
| internal/cli/misc.go | Emits conformance block in schema output; implements version --check structured output. |
Files not reviewed (1)
- site/pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+77
to
+82
| req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| req.Header.Set("Accept", "application/vnd.github+json") | ||
| resp, err := http.DefaultClient.Do(req) |
Comment on lines
+84
to
+86
| The conformance block is machine-verifiable from the binary itself — `vabc schema --json` emits | ||
| `{ "spec": "agent-cli-guidelines", "version": "0.4.0", "level": "Full" }` — so an agent can confirm | ||
| the contract version without trusting this badge. |
- Bump @astrojs/starlight ^0.30 -> ^0.31 so starlight-llms-txt's >=0.31 peer is satisfied; keeps the social-object config (pre-0.33) and still generates /llms.txt (verified via pnpm install + build). - Add User-Agent header to internal/version Latest() (GitHub REST rejects UA-less requests) and fix UpgradeHint to /cmd/<tool>@latest, mirroring the examplectl factory template. - README: show the conformance object nested under the top-level "conformance" key as valid JSON matching `vabc schema --json`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012UFrhC6bXVpoiiL3yhj2HH
Owner
Author
|
Addressed all three Copilot review comments in fa68b4b:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls
vabcup to Agent CLI Guidelines v0.4.0, targeting Full conformance. Mirrors the factory Go templates (examplectl:internal/version/version.go,internal/cli/misc.go) and contract §5/§11.Per-rule checklist
schema(§5) —schema --jsonnow emits"conformance": { "spec": "agent-cli-guidelines", "version": "0.4.0", "level": "Full" }, backed by a newconst Spec = "0.4.0"ininternal/version. Verified from the built binary.version --check(§11) — pull-based, structured{current, latest, updateAvailable, upgrade}against GitHub Releases, 3s timeout, fail-silent (returns anote+ exit 0 on any network problem; never blocks an agent loop). AddedLatest/UpdateAvailable/UpgradeHinthelpers. Overridable viaVABC_RELEASES_URLfor tests. Verified live (update detected) and offline (fail-silent)./llms.txton the docs site — added thestarlight-llms-txtplugin tosite/astro.config.mjs+site/package.json.pnpm buildnow emits/llms.txt,/llms-full.txt,/llms-small.txt. (Pinned plugin^0.4.0to stay compatible with the site's Starlight 0.30 / Astro 5; avoids the Starlight 0.33social-config breaking change.)schema --jsonconformance block.Notes
--checkflag + conformance block (VABC_UPDATE_GOLDEN=1).Verification
go build ./...— greengo test ./...— 23 passed (incl. theTestSchemaSnapshotcontract gate)vabc schema --json— conformance block presentvabc version --check— structured + fail-silent confirmedpnpm build(site) — green, llms.txt generated🤖 Generated with Claude Code
https://claude.ai/code/session_012UFrhC6bXVpoiiL3yhj2HH