Add support for USB logging on peripheral - #1000
Conversation
|
Thanks for the work! Comments from me:
|
|
New version:
The log level filter in embassy_usb_logger is set to trace, so all levels are supported without changing the code.
I think I should work for rp2040 too, I can not test it though.
I combined the logic of I'm unsure though, if both features run together, as I could not test it at the moment. |
4ede2b2 to
421e500
Compare
421e500 to
2f6b932
Compare
Size Report
|
Adds usb init function and logging task for the peripheral depending on the
usb_logfeature flag.Should this be a separate feature?
Currently this works for nrf52 only, should I add support for rp2040?
Currently peripheral usb logging is mutually exclusive with dfu, should I create a common usb_task for the two? Would that even work with the available hardware resources?
It changes the default log level to trace, so one can change the log level without touching rmk code. I added docs for this.
Let me know if I should change anything.