Skip to content

fix(miles-pipeline): narrow startup-validation import guard to ModuleNotFoundError #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TianyeGGBond wants to merge 1 commit into
base: zhenyu/miles-mvp-e2e
Choose a base branch
from
Open

fix(miles-pipeline): narrow startup-validation import guard to ModuleNotFoundError #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions rlix/pipeline/miles_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,14 @@ def _validate_topology(self, pipeline_config: Any) -> None:
return
try:
from miles.utils.rlix_validation import assert_rlix_topology
except Exception as exc: # noqa: BLE001
except ModuleNotFoundError as exc:
# miles not installed (test/dev fixture). A partial or broken
# install raises ImportError/SyntaxError and must NOT be swallowed
# here — in production miles is always importable, so those signal
# a real bug and should fail fast.
logger.warning(
"MilesPipeline: miles.utils.rlix_validation unavailable; "
"skipping startup validation: %r",
"MilesPipeline: miles not installed; skipping F10 startup "
"validation (test-fixture path): %r",
exc,
)
return
Expand Down