Skip to content

Fix/issue 3300 xrefs width #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
urvashislash wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix/issue 3300 xrefs width #3522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c396675
Fix: limit XRefs table column width to prevent overflow (Issue #3300)
urvashislash Nov 4, 2025
f3c2ac1
Fix: adjusted XrefDialog column width issue (#3300)
urvashislash Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions external/rizin
Open in desktop
Copy link
Copy Markdown
Member

@wargio wargio Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Submodule rizin added at fb008a
24 changes: 24 additions & 0 deletions src/dialogs/XrefsDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,18 @@ void XrefsDialog::fillRefsForAddress(RVA addr, QString name, bool whole_function
// Adjust columns to content
qhelpers::adjustColumns(ui->fromTreeWidget, fromModel.columnCount(), 0);
qhelpers::adjustColumns(ui->toTreeWidget, toModel.columnCount(), 0);
// Prevent columns from exceeding a maximum width (e.g., 400px)
for (int i = 0; i < ui->fromTreeWidget->header()->count(); ++i) {
int width = ui->fromTreeWidget->columnWidth(i);
if (width > 400)
ui->fromTreeWidget->setColumnWidth(i, std::min(width, 400));
}
for (int i = 0; i < ui->toTreeWidget->header()->count(); ++i) {
int width = ui->toTreeWidget->columnWidth(i);
if (width > 400)
ui->toTreeWidget->setColumnWidth(i, std::min(width, 400));
}


// Automatically select the first line
if (!qhelpers::selectFirstItem(ui->toTreeWidget)) {
Expand All @@ -205,6 +217,18 @@ void XrefsDialog::fillRefsForVariable(QString nameOfVariable, RVA offset)
// Adjust columns to content
qhelpers::adjustColumns(ui->fromTreeWidget, fromModel.columnCount(), 0);
qhelpers::adjustColumns(ui->toTreeWidget, toModel.columnCount(), 0);
// Prevent columns from exceeding a maximum width (e.g., 400px)
for (int i = 0; i < ui->fromTreeWidget->header()->count(); ++i) {
int width = ui->fromTreeWidget->columnWidth(i);
if (width > 400)
ui->fromTreeWidget->setColumnWidth(i, std::min(width, 400));
}
for (int i = 0; i < ui->toTreeWidget->header()->count(); ++i) {
int width = ui->toTreeWidget->columnWidth(i);
if (width > 400)
ui->toTreeWidget->setColumnWidth(i, std::min(width, 400));
}


// Automatically select the first line
if (!qhelpers::selectFirstItem(ui->toTreeWidget)) {
Expand Down