Changed menu letter-casing to 'sentence-style' capitalization#3381
Open
agedpage wants to merge 1 commit intorizinorg:devfrom
Open
Changed menu letter-casing to 'sentence-style' capitalization#3381agedpage wants to merge 1 commit intorizinorg:devfrom
agedpage wants to merge 1 commit intorizinorg:devfrom
Conversation
XVilka
requested changes
Oct 4, 2024
Member
XVilka
left a comment
XVilka
left a comment
There was a problem hiding this comment.
Please remove irrelevant changes
| <y>127</y> | ||
| <width>151</width> | ||
| <height>312</height> | ||
| <x>339</x> |
| </property> | ||
| <property name="contextMenuPolicy"> | ||
| <enum>Qt::DefaultContextMenu</enum> | ||
| <enum>Qt::ContextMenuPolicy::DefaultContextMenu</enum> |
| </property> | ||
| <property name="toolButtonStyle"> | ||
| <enum>Qt::ToolButtonIconOnly</enum> | ||
| <enum>Qt::ToolButtonStyle::ToolButtonIconOnly</enum> |
| </property> | ||
| <property name="icon"> | ||
| <iconset> | ||
| <iconset resource="../resources.qrc"> |
Member
|
@ArmanChowdhury449 ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
There is some clear inconsistency in the capitalization of some menu item. Looking at the discussion under issue #2331, it appeared that sentence-style casing appears as a choice on many style guides. It's been a while since the issue was opened and it was an easy fix, so I went ahead and made the change.
Test plan (required)
Here are a couple inconsistent menus:
After changing the capitalization, they look like this:
Closing issues
closes #2331