Graph widget - do not print basic block address - Fixed #3150
Closed
M-ismail-ramzan wants to merge 1 commit intorizinorg:devfrom
M-ismail-ramzan:dev
Closed
Graph widget - do not print basic block address - Fixed #3150M-ismail-ramzan wants to merge 1 commit intorizinorg:devfrom M-ismail-ramzan:dev
M-ismail-ramzan wants to merge 1 commit intorizinorg:devfrom
M-ismail-ramzan:dev
Conversation
Member
|
It still should be shown if the |
Author
Alright, Am working on it. |
Author
|
Kindly see #3154 for further Updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for this pull request
Detailed description
To make these changes, I removed the lines that were responsible for rendering the "Extra Address" section, and I also removed the lines that were increasing the height of the graph block.
Test plan (required)
I have converted the design from taking up extra space on the screen (see image 1) to the design with a reduced block height, which saves space on the screen (see image 2).
Image 1

Image 2

Code formatting
Make sure you ran clang-format on your code before making the PR. Check our contribution guidelines here: https://cutter.re/docs/contributing/code/getting-started.html -->
Closing issues
This pull request closes issue #3144.