Skip to content

Graph widget - do not print basic block address - Fixed #3150

Closed
M-ismail-ramzan wants to merge 1 commit intorizinorg:devfrom
M-ismail-ramzan:dev
Closed

Graph widget - do not print basic block address - Fixed #3150
M-ismail-ramzan wants to merge 1 commit intorizinorg:devfrom
M-ismail-ramzan:dev

Conversation

@M-ismail-ramzan
Copy link
Copy Markdown

Checklist for this pull request

Detailed description

To make these changes, I removed the lines that were responsible for rendering the "Extra Address" section, and I also removed the lines that were increasing the height of the graph block.

Test plan (required)
I have converted the design from taking up extra space on the screen (see image 1) to the design with a reduced block height, which saves space on the screen (see image 2).

Image 1
image

Image 2
image

Code formatting
Make sure you ran clang-format on your code before making the PR. Check our contribution guidelines here: https://cutter.re/docs/contributing/code/getting-started.html -->

Closing issues
This pull request closes issue #3144.

@M-ismail-ramzan M-ismail-ramzan changed the title Graph widget - do not print basic block address - Fixed Graph widget - do not print basic block address - Fixed Mar 25, 2023
@XVilka
Copy link
Copy Markdown
Member

XVilka commented Mar 27, 2023

It still should be shown if the graph.offsets option is unset, since there should be no offsets printed by default for every instruction. See the comment to the original issue on details.

@M-ismail-ramzan
Copy link
Copy Markdown
Author

It still should be shown if the graph.offsets option is unset, since there should be no offsets printed by default for every instruction. See the comment to the original issue on details.

Alright, Am working on it.

@M-ismail-ramzan M-ismail-ramzan closed this by deleting the head repository Mar 29, 2023
@M-ismail-ramzan
Copy link
Copy Markdown
Author

Kindly see #3154 for further Updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants