edns: allow dnsconfd name resolution for kickstart fetching#6352
Merged
M4rtinK merged 2 commits intoApr 25, 2025
Merged
Conversation
Start dnsconfd already before kickstart fetching. We used to start dnsconfd only after the kickstart was fetched if kickstart usage was detected so that the potential certificates from kikcstart are applied. But this mechanism ruled out use case when dnsconfd (name resolution) is needed for the kickstart fetching. So start the dnsconfd early and if certificates were fetched restart it (it is done by restarting unbound service as recommended by dnsconfd). Resolves: RHEL-82694
rvykydal
changed the title
Contributor
Author
|
/kickstart-test --testtype dns |
Contributor
Author
|
/build-image |
|
Images built based on commit c5d903f:
Download the images from the bottom of the job status page. |
Contributor
Author
|
/kickstart-test --testtype smoke |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @rvykydal - I've reviewed your changes - here's some feedback:
Overall Comments:
- The logic in
start_dnsconfdseems complex; consider simplifying it or breaking it down into smaller functions for better readability. - It might be helpful to add more comments within the
start_dnsconfdfunction to explain the purpose of each conditional check.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
We need this guard because kickstart may be fetched over multiple network devices and it is parsed after each fetching. Parsing itself should be idempotent (multiple parsing harmless) as it only dumps files with configuration / options for further actions. Resolves: RHEL-82694
rvykydal
force-pushed
the
restart-bind-after-fetching-certs-rhel9
branch
from
c5d903f to
958e2be
Compare
Contributor
Author
|
/kickstart-test --testtype smoke |
Contributor
Author
|
/kickstart-test --testtype dns |
rvykydal
added
the
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of upstream #6258
Resolves: RHEL-82694