Repository navigation
fix(routing): New South Wales is Australia, Índia and U.S. are found, beber isn't a baby - #82
Conversation
… beber isn't a baby - 'Wales' inside 'New South Wales' gave the UK's 999 for a question naming Australia; 'New South Wales' now names Australia. - 'Índia': JavaScript's \b is ASCII-only, so no boundary before 'Í'; matched with a letter lookbehind instead. - 'U.S.' before '?' or at the end: \b after the last dot needed a word character. - PT 'bebê' as a prefix matched 'beber' and 'bebendo', tagging drinking-water questions as 'child'. Found by CodeRabbit on the Kotlin port, which copies these rules.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The change fixes four country-name and Portuguese term matching bugs and adds tests for them. No merge-blocking risk was identified. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description Check | |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly summarizes the main routing fixes: New South Wales matching Australia, India and U.S. recognition, and preventing beber from matching bebê. |
✨ Finishing Touches
-
-
📝 Generate docstrings
-
-
-
- Commit to this branch
- Create a new PR
-
-
🧪 Generate unit tests (beta)
-
-
- Commit to this branch
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
1 participant
Four matching bugs in the offline emergency-number table and the Portuguese search terms. CodeRabbit found them on the native app's Kotlin port, which copies these rules, so the TS is fixed here and the Kotlin on fullnative-dev (749215b) with the same regexes.
\bis ASCII-only, no boundary before "Í")\bafter the last dot needs a letter)child("bebê" matched as a prefix of "beber")"Wales" alone still gives the UK, and "Indiana" gives nothing.
Tests: 7 new cases in
emergencyNumbers.test.tsandptQuery.test.ts.npm test1177/1177, typecheck clean. CodeRabbit (cr review --base main): no findings.Summary by CodeRabbit