Clear the stale drain deadline on a re-adopted ReplicaSet - #179
Open
darkmuggle wants to merge 1 commit into
Open
Clear the stale drain deadline on a re-adopted ReplicaSet#179darkmuggle wants to merge 1 commit into
darkmuggle wants to merge 1 commit into
Conversation
A ReplicaSet re-adopted as the current version was previously superseded, so it can still carry the removal deadline stamped on it while it drained. Nothing else clears it: the annotation patch on that path uses a different field manager, so server-side apply won't prune it, and cleanup_old_replicasets skips the current version via except_rs. Left in place, an already-past deadline makes the next rollout tear this version down immediately instead of giving it drainDelaySeconds, stranding whatever is still pinned to it. Refs #174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ReplicaSet re-adopted as the current version was previously superseded, so it can still carry the removal deadline stamped on it while it drained. Nothing else clears it: the annotation patch on that path uses a different field manager, so server-side apply won't prune it, and cleanup_old_replicasets skips the current version via except_rs.
Left in place, an already-past deadline makes the next rollout tear this version down immediately instead of giving it drainDelaySeconds, stranding whatever is still pinned to it.
Refs #174