Force existing non-latest deployments back to latest - #160
Open
titanous wants to merge 1 commit into
Open
Conversation
Re-register an existing non-latest deployment with force=true so rollback makes it latest again, including inactive historical deployments.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a RestateDeployment is rolled back to a version whose deployment record still exists but is no longer latest, re-register it with force=true. This makes rollback converge instead of reusing an old deployment ID while a newer version remains latest. The decision distinguishes existing latest, existing non-latest (active or inactive), and missing records, with focused unit coverage. The registration request path is shared by ReplicaSet and Knative modes.