Skip to content

TRestDetectorElectronDiffusionProcess fix when several readout planes #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlvaroEzq wants to merge 6 commits into
base: master
Choose a base branch
from
Open

TRestDetectorElectronDiffusionProcess fix when several readout planes #128

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
977a13b
set checkIsInside to true by default
AlvaroEzq May 24, 2026
90625cf
allow 0 long or trans diffusion coeff to disable them
AlvaroEzq May 24, 2026
b2c26fb
improve code readability
AlvaroEzq May 24, 2026
1dcd63c
avoid duplicated processing of hit when several planes
AlvaroEzq May 24, 2026
454f44c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 24, 2026
ffc32c0
Trigger CI: pick up restG4 validation reference fix
cmargalejo Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions src/TRestDetectorElectronDiffusionProcess.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ void TRestDetectorElectronDiffusionProcess::Initialize() {
fAttachment = 0;
fGasPressure = -1;

fTransversalDiffusionCoefficient = 0;
fLongitudinalDiffusionCoefficient = 0;
fTransversalDiffusionCoefficient = -1;
fLongitudinalDiffusionCoefficient = -1;
fWValue = 0;
fFanoFactor = 0;

Expand All @@ -58,6 +58,7 @@ void TRestDetectorElectronDiffusionProcess::Initialize() {
fReadout = nullptr;

fRandom = nullptr;
fCheckIsInside = true;
}

void TRestDetectorElectronDiffusionProcess::LoadConfig(const string& configFilename, const string& name) {
Expand Down Expand Up @@ -116,11 +117,11 @@ void TRestDetectorElectronDiffusionProcess::InitProcess() {
fFanoFactor = fGas->GetGasFanoFactor();
}

if (fLongitudinalDiffusionCoefficient <= 0) {
if (fLongitudinalDiffusionCoefficient < 0) {
fLongitudinalDiffusionCoefficient = fGas->GetLongitudinalDiffusion();
} // (cm)^1/2

if (fTransversalDiffusionCoefficient <= 0) {
if (fTransversalDiffusionCoefficient < 0) {
fTransversalDiffusionCoefficient = fGas->GetTransversalDiffusion();
} // (cm)^1/2
}
Expand Down Expand Up @@ -184,7 +185,7 @@ TRestEvent* TRestDetectorElectronDiffusionProcess::ProcessEvent(TRestEvent* inpu
const Double_t z = hits->GetZ(hitIndex);

for (int p = 0; p < fReadout->GetNumberOfReadoutPlanes(); p++) {
TRestDetectorReadoutPlane* plane = &(*fReadout)[p];
TRestDetectorReadoutPlane* plane = fReadout->GetReadoutPlane(p);
const auto planeType = plane->GetType();
if (planeType == "veto") {
// do not drift veto planes
Expand Down Expand Up @@ -238,18 +239,29 @@ TRestEvent* TRestDetectorElectronDiffusionProcess::ProcessEvent(TRestEvent* inpu
}

TVector3 positionAfterDiffusion = {x, y, z};
positionAfterDiffusion += {
fRandom->Gaus(0, transversalDiffusion), //
fRandom->Gaus(0, transversalDiffusion), //
fRandom->Gaus(0, longitudinalDiffusion) //
};
if (plane->GetDistanceTo(positionAfterDiffusion) < 0) {
if (transversalDiffusion > 0) {
positionAfterDiffusion += {
fRandom->Gaus(0, transversalDiffusion), //
fRandom->Gaus(0, transversalDiffusion), //
0 //
};
}
if (longitudinalDiffusion > 0) {
positionAfterDiffusion += {
0, //
0, //
fRandom->Gaus(0, longitudinalDiffusion) //
};
}

if (plane->GetDistanceTo(positionAfterDiffusion) < 0 && longitudinalDiffusion > 0) {
// electron has been moved under the plane
positionAfterDiffusion.SetZ(
plane->GetPosition().Z() +
1E-6 * plane->GetNormal().Z()); // add a delta to make sure readout finds it
}
if (plane->GetDistanceTo(positionAfterDiffusion) > plane->GetHeight()) {
if (plane->GetDistanceTo(positionAfterDiffusion) > plane->GetHeight() &&
longitudinalDiffusion > 0) {
// electron has been moved over the plane
positionAfterDiffusion.SetZ(
plane->GetPosition().Z() + plane->GetHeight() -
Expand All @@ -272,6 +284,7 @@ TRestEvent* TRestDetectorElectronDiffusionProcess::ProcessEvent(TRestEvent* inpu
}
fOutputHitsEvent->AddHit(positionAfterDiffusion.X(), positionAfterDiffusion.Y(),
positionAfterDiffusion.Z(), electronEnergy, time, type);
break; // avoid redoing for other planes (happens if fCheckIsInside is false)
}
}
}
Expand Down Expand Up @@ -319,6 +332,6 @@ void TRestDetectorElectronDiffusionProcess::InitFromConfigFile() {
fSeed = static_cast<UInt_t>(StringToInteger(GetParameter("seed", "0")));
fPoissonElectronExcitation = StringToBool(GetParameter("poissonElectronExcitation", "true"));
fUnitElectronEnergy = StringToBool(GetParameter("unitElectronEnergy", "false"));
fCheckIsInside = StringToBool(GetParameter("checkIsInside", "false"));
fCheckIsInside = StringToBool(GetParameter("checkIsInside", "true"));
fUseFanoFactor = StringToBool(GetParameter("useFano", "false"));
}
Loading