Skip to content

fix: use tds row check instead of account (backport #4949) - #4988

Open
mergify[bot] wants to merge 1 commit into
version-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-4949
Open

mergify[bot] wants to merge 1 commit into
version-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-4949

Conversation

@mergify

@mergify mergify Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Issue: In v16 we have already introduce checkbox for TDS row.

Accepted regression: Taxable value in PO and SO now includes TDS amounts. TDS account is not supposed to be used / not required / not useful in PO and SO


This is an automatic backport of pull request #4949 done by Mergify.

(cherry picked from commit 326fe3d)

# Conflicts:
#	india_compliance/gst_india/overrides/transaction.py
@mergify mergify Bot added the conflicts label Oct 7, 2026
@mergify

mergify Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 326fe3d has failed:

On branch mergify/bp/version-16-hotfix/pr-4949
Your branch is up to date with 'origin/version-16-hotfix'.

You are currently cherry-picking commit 326fe3d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   india_compliance/gst_india/overrides/test_transaction.py
	modified:   india_compliance/gst_india/report/gst_account_wise_summary/gst_account_wise_summary.py
	modified:   india_compliance/hooks.py
	modified:   india_compliance/income_tax_india/overrides/tax_withholding_category.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   india_compliance/gst_india/overrides/transaction.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 2 critical

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category Results
Security 2 critical

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant