Closed
Conversation
Treat forward sequence gaps as unrecoverable session state so reconnects create a fresh connection instead of reusing a poisoned session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Out-of-order River messages currently only close the active connection, which lets poisoned sessions transparently reconnect and repeat the same sequencing failure. This hardens recovery so corrupted sessions reconnect cleanly instead of reusing broken state.
What changed
Versioning
Test plan
direnv exec /home/developer/replit/river npm exec eslint -- transport/sessionStateMachine/SessionConnected.ts transport/client.ts transport/server.ts transport/sessionStateMachine/stateMachine.test.ts transport/transport.test.tsdirenv exec /home/developer/replit/river npm run test:single -- transport/sessionStateMachine/stateMachine.test.ts transport/transport.test.tsRevertibility
Safe to revert. This only changes River transport recovery behavior and tests; it does not change the wire schema or any persisted state.
~ written by Zerg 👾