Skip to content

docs(app-fees): add feature page intro - #387

Open
scout-relayprotocol[bot] wants to merge 2 commits into
mainfrom
scout/MAR-1411-app-fees-intro
Open

docs(app-fees): add feature page intro#387
scout-relayprotocol[bot] wants to merge 2 commits into
mainfrom
scout/MAR-1411-app-fees-intro

Conversation

@scout-relayprotocol

Copy link
Copy Markdown

Implements MAR-1411: App Fees feature page intro

What this changes

  • Adds the approved App Fees positioning and monetization introduction to features/app-fees.mdx.
  • Adds concise sections covering how it works, benefits, target integrators, capabilities, and limitations above the existing technical guide.
  • Leaves out the pending rev-share cross-link and dashboard earnings tie-in until those launches are ready.

How I verified

  • git diff --check passes.
  • Reviewed the final MDX diff against the approved Notion copy and the repository style guide.
  • No local docs validation scripts or package manifest are available in this repository; final rendering is left to the docs preview/PR review.

Open questions

  • None.

🤖 Opened by Scout (autonomous). Ready for human review.
Linear: https://linear.app/relayprotocol/issue/MAR-1411/app-fees-feature-page-intro

Add the approved marketing introduction above the existing App Fees integration guide. Keep the pending rev-share cross-link and dashboard earnings tie-in out until their launches are ready.\n\nLinear: MAR-1411
@mintlify

mintlify Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
unevenlabs 🟢 Ready View Preview Jul 31, 2026, 10:55 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Claude finished @jmaier6's task in 2m 17s —— View job


Code review: App Fees feature page intro

  • Gather context (diff, full file, style guide)
  • Check style-guide conformance (AGENTS.md §2/§3.1)
  • Check for broken anchors / inbound links
  • Check content accuracy vs. rest of page
  • Post review

The new intro reads well and the tighter second commit is a clear improvement over the first. But the PR also does something its description doesn't mention: it demotes seven existing headings in the technical guide to bold text. That's the bulk of my feedback.


1. Seven ##/### sections were demoted to bold lead-ins (structural regression)

features/app-fees.mdx:36,48,63,71,85,117,195Additional Considerations, Supported Transaction Types, Chain-Specific Notes, Verifying Fee Collection, Get App Balance, How to withdraw your off-chain balance?, and Withdrawing via a smart contract all became **bold**.

Three concrete consequences:

  • AGENTS.md §2.2 says the opposite. ## is the primary body heading, ### is for subsections, and bold lead-ins are for subdivisions smaller than ###. These are full sections — one contains a 10-row table, another holds ~40 lines of curl/SDK examples.
  • Broken nesting. ## Setting up App Fees (line 23) now swallows everything through line 77, including Supported transaction types and Verifying fee collection. Neither is a sub-step of setting up fees; they were peer sections on main.
  • TOC collapse. Mintlify's "On this page" builds from h2/h3. A ~200-line page drops from 11 entries to 4. Every other page in features/ keeps a dense ##/### tree (deposit-addresses.mdx has 24, fee-sponsorship.mdx has 15) — app-fees is now the outlier.

Related: line 45 lost a working in-page link. The Warning used to say [monitoring endpoints](#verifying-fee-collection); because the target heading no longer generates an anchor, it was flattened to plain prose "the verification endpoints described below". Restoring the headings restores the link.

Suggested: keep ## Supported Transaction Types and ## Verifying Fee Collection at ##, and make Additional Considerations / Chain-Specific Notes / the three withdrawal subsections ### under their parents.

Fix this →

Also worth noting: **Chain-specific notes** on line 63 is immediately followed by **EVM (same-chain):**, **SVM (same-chain):**, **Cross-chain…:** — the section label and its items now render identically, so there's no visual hierarchy left at all.


2. The page no longer defines what an App Fee is

Commit 8e4fd94 deleted the ## What are App Fees? paragraph, which carried two things the new intro doesn't replace:

  • The definition: "App fees are additional fees set by third-party developers on top of existing fees" — i.e. app fees stack on Relay's own fees. The new intro says what App Fees let you do, never what they are.
  • The rationale: "To improve the gas costs of fee setting, App fees are not paid out in real-time." This is the why behind offchain accrual. The new intro states accrual as a bare fact, so a reader hitting the claim flow has no idea why they can't just receive fees directly.

AGENTS.md §3.1 asks the intro to open with definitional framing (<FeatureName> is a feature that … or similar). Folding one definitional sentence into the intro would satisfy both the profile and the lost content.


3. Frontmatter description overclaims

features/app-fees.mdx:3 — "Add your own fees to any Relay transaction" contradicts the Warning at line 45 and the support table at line 59 (Sends / Transfers ❌, Gasless execution (no prior quote) ❌). The body intro gets this right with "supported transactions"; the description doesn't. This string renders in search results and nav previews, so it's the first thing a reader trusts.

Suggest: "Add your own fees to supported Relay transactions and collect in stablecoins".

Fix this →


4. "Single USDC balance" may conflict with the rest of the page

features/app-fees.mdx:6,12,19 assert a single USDC balance. Further down:

  • Line 81: "can be claimed on any chain … or in any other currency"
  • Line 87: "the balances.currency field reflecting your off-chain balance for each currency accumulated"

If accrual really is USDC-only and only the claim is multi-currency, the new copy is fine and line 87 is the stale one. If balances can accrue in multiple currencies, the new intro is wrong in three places. Worth confirming with whoever owns the balances API rather than guessing — but the page shouldn't ship saying both.

Similarly, line 6 says "Claim your balance for free on Base" while line 81 says any chain, free on Base. Not a contradiction, but the intro reads as if Base is the only option.


Nits

  • features/app-fees.mdx:6 — the intro is four sentences; AGENTS.md §2.10 caps paragraphs at 2–3. Splitting after "…when the transaction settles." fixes it.
  • features/app-fees.mdx:11-12 — steps 2 and 3 overlap. Step 2 already says "Relay collects the fee at settlement"; step 3 says "Collect fees — Collected fees accrue…". Consider merging, or retitling step 3 to "Accrue in USDC".
  • PR description is stale. It says the PR adds sections for "target integrators, capabilities, and limitations" and omits a rev-share cross-link. Commit 8e4fd94 removed all of those (including the "app fees are distinct from rev share" line, which was present in commit eb012e1). Reviewers reading the description will look for sections that aren't there.

What I checked and found clean

  • No inbound links from other pages target the demoted anchors — I grepped all app-fees references across the repo, and every one is a bare /features/app-fees link with no fragment. The only casualty was the in-page link noted above.
  • docs.json:43 needs no change; Mintlify nav points at the page, not its headings.
  • git diff --check is clean, and no code samples, tables, or API references were altered.

I did not run a docs build — this repo has no package manifest or validation script, so link and MDX validation is left to the Mintlify preview.
· scout/MAR-1411-app-fees-intro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant