Repository navigation
Twins cleanup - #276
Merged
Merged
Twins cleanup#276
Conversation
In a recent change, the partitions now require a full NodeID, and thus the fhsBugScenario failed to parse the old JSON format.
This simplifies creating custom consensus rules for twins.
This harmonizes the creation of the TimeoutRuler to be based only on the RuntimeConfig instead of custom if-else logic scattered around the codebase.
This makes it possible to pass down runtime options specific for a given scenario, e.g., if we use fasthotstuff, we need to pass the WithAggregateQC() option.
We now have a global NewTimeoutRuler() constructor function that encapsulate all TimeoutRulers. This replaces existing calls to NewSimple and NewAggregate and unexports these.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes several bugs and fixes the initialization approach for the timeout ruler and consensus ruler.
Fixes #189