chore: Remove RuntimeConfig dependency from client.New

[Copilot]

client.New() required a RuntimeConfig parameter solely to extract the client ID. Additionally, clients reused hotstuff.ID despite being distinct from replica IDs.

Changes

• client/client.go: Added client.ID type; replaced config *core.RuntimeConfig field with id ID; updated New() signature
• internal/proto/orchestrationpb/client_opts.go: Added ClientID() helper to convert ClientOpts.ID to client.ID
• internal/orchestration/worker.go: Changed clients map from map[hotstuff.ID] to map[client.ID]; removed RuntimeConfig instantiation; pass opts.ClientID() directly to client.New()

Before

runtimeCfg := core.NewRuntimeConfig(hotstuff.ID(opts.GetID()), nil)
cli := client.New(eventLoop, logger, runtimeCfg, c)
w.clients[hotstuff.ID(opts.GetID())] = cli

After

cli := client.New(eventLoop, logger, opts.ClientID(), c)
w.clients[opts.ClientID()] = cli

Original prompt

---

This section details on the original issue you should resolve

<issue_title>chore: client.New requires RuntimeConfig only to get the client's ID</issue_title>
<issue_description>Clients are created in startClients from internal/orchestration/worker.go:

		runtimeCfg := core.NewRuntimeConfig(hotstuff.ID(opts.GetID()), nil)

		cli := client.New(
			eventLoop,
			logger,
			runtimeCfg,
			c,
		)

In client.sendCommands() we do this:

		cmd := &clientpb.Command{
			ClientID:       uint32(c.config.ID()),
			SequenceNumber: num,
			Data:           data[:n],
		}

This is the only usage of the c.config field. We should instead just pass the client.ID in New. See below for more details.

Moreover, there is this map in worker.go:

	clients  map[hotstuff.ID]*client.Client

We should not use the same ID for hotstuff replicas and clients. We should create a new ID type in the client package (client/client.go):

type ID uint32

Along with a helper method in a new file internal/proto/orchestrationpb/client_opts.go:

package orchestrationpb

import (
	"github.com/relab/hotstuff/client"
)

func (x *ClientOpts) ClientID() client.ID {
	return client.ID(x.GetID())
}

We can then use opts.ClientID() directly instead of passing the RuntimeConfig as shown above. That is, we should have this function in the client package:

// New returns a new Client.
func New(
	eventLoop *eventloop.EventLoop,
	logger logging.Logger,
	id ID,
	conf Config,
) (client *Client) {

And use it like this from worker.go:

		cli := client.New(
			eventLoop,
			logger,
			opts.ClientID(),
			c,
		)
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

• Fixes chore: client.New requires RuntimeConfig only to get the client's ID #272

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.