[v25.2.x] iceberg: set MAP logical type on parquet map columns#30456
Open
vbotbuildovich wants to merge 3 commits into
Open
[v25.2.x] iceberg: set MAP logical type on parquet map columns#30456vbotbuildovich wants to merge 3 commits into
vbotbuildovich wants to merge 3 commits into
Conversation
Without the LogicalType.MAP annotation, strict parquet readers (Spark via SparkParquetReaders) fail with "Not a struct type" when reading the column, even though `describe` reports the column as a map. The declared type lives in the iceberg metadata and is unaffected by the missing annotation; only column read-back was broken. Mirror the LIST converter and stamp the annotation on the map root element. Cover with a unit-test assertion that the annotation is present and an end-to-end ducktape test that exercises map read-back via both Spark and Trino. (cherry picked from commit 4ae42da)
Trino's parquet reader is permissive enough to accept a map column written without the LogicalType.MAP annotation, so the engine-side assertion alone misses regressions that only show up in stricter readers. Add a pyiceberg read-back step that scans the column via arrow; pyiceberg rejects the malformed file (different failure mode than Spark) which gives us coverage independent of the query engine. (cherry picked from commit 5bfb4d3)
wdberkeley
approved these changes
May 13, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Diff was identical to original but failed clang-format on this branch. Pushed formatting-only commit on top. |
Collaborator
Author
Retry command for Build#84387please wait until all jobs are finished before running the slash command |
Collaborator
Author
CI test resultstest results on build#84387
|
Contributor
|
/ci-repeat 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30454