rptest: Model test revamp#30455
Merged
Merged
Conversation
`redpanda.storage.mode=tiered` atomically enables both archival (remote
write) and remote fetch (remote read) on a topic. Once it is non-unset
the legacy `redpanda.remote.{read,write}` and cluster-level
`cloud_storage_enable_remote_{read,write}` paths are bypassed entirely
(see `topic_properties::is_archival_enabled` / `is_remote_fetch_enabled`
in cluster/topic_properties.cc).
Collapse the four `Remote{Read,Write}{Topic,Cluster}Config` expressions
into a single `StorageModeTiered` input. The two `ts_{read,write}`
constraints that used to ORed over the four-way split now require this
single input. Also drop the find_all_solutions group whose only purpose
was to enumerate the topic-vs-cluster enablement combinations -- the
new property makes that distinction meaningless.
Signed-off-by: Evgeny Lazin <4lazin@gmail.com>
`TopicCompactionEnabled` and `EnableSegmentMs` each carried one or two
ClusterConfigInputs whose only purpose was to tune the test environment
so the corresponding topic-level property produces observable effects in
test duration:
max_compacted_log_segment_size - cap compacted segments at 1 MB so
compaction reupload fires.
log_compaction_interval_ms - speed up the housekeeping loop so
segment.ms rolls land inside the
test window.
log_segment_ms_min - lower the global floor on segment.ms
so the topic's segment.ms is honored.
None of these are features under test; they're inert unless a topic
opts into compaction or segment.ms. Lift them into the cluster
bootstrap (extra_rp_conf in TieredStorageTest.__init__) so both inputs
are now purely topic-config (plus, for compaction, a producer hint that
makes the data compactable).
This is a step toward splitting inputs into topic-only and cluster-only
groups so a single ducktape run can drive multiple sub-cases over many
topics on the same cluster.
Signed-off-by: Evgeny Lazin <4lazin@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR revamps the tiered-storage model test inputs to reduce model size and simplify configuration by switching to the unified redpanda.storage.mode topic property (instead of separate remote read/write flags) and by moving previously per-case cluster tuning into the test’s cluster bootstrap configuration.
Changes:
- Replace legacy topic/cluster remote read+write configuration inputs with a single
StorageModeTieredtopic-config input (redpanda.storage.mode=tiered) that gates both upload and remote fetch paths. - Remove per-test-case cluster config inputs for compaction/segment.ms tuning and apply them once via
TieredStorageTest.extra_rp_confduring cluster startup. - Remove test-case generation that explicitly validated the legacy “topic vs cluster” remote-read/write enablement combinations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/rptest/tests/tiered_storage_model.py |
Collapses tiered-storage enablement to redpanda.storage.mode=tiered and removes legacy remote read/write input combinations and related constraints. |
tests/rptest/tests/tiered_storage_model_test.py |
Moves compaction/segment.ms-related cluster tuning into startup extra_rp_conf so model inputs remain topic-scoped. |
Collaborator
CI test resultstest results on build#84380
|
andrwng
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revisit the model test.
Use
storage.modeinstead ofreadandwriteflags and collapse bothsegment.msandcompactioncluster/topic level inputs together. This reduces the size of the model.Backports Required
Release Notes