Skip to content

dt/tests: bump IBM/sarama and franz-go for Kafka 4.x test alignment#30451

Open
nguyen-andrew wants to merge 2 commits into
redpanda-data:devfrom
nguyen-andrew:CORE-16243
Open

dt/tests: bump IBM/sarama and franz-go for Kafka 4.x test alignment#30451
nguyen-andrew wants to merge 2 commits into
redpanda-data:devfrom
nguyen-andrew:CORE-16243

Conversation

@nguyen-andrew
Copy link
Copy Markdown
Member

@nguyen-andrew nguyen-andrew commented May 12, 2026

Bumps two Go test clients to versions aligned with Kafka 4.latest,
continuing the ENG-1185 effort.

IBM/sarama: v1.45.1 → v1.48.0

The pin lives in two places that have to move together:

  • tests/go/sarama/produce_test/go.mod (the produce_test binary
    driven by SaramaProduceTest).
  • tests/docker/ducktape-deps/sarama-examples (the clone-and-build
    script for the four example binaries driven by SaramaTest).

The sibling tests/go/sarama/produce_legacy_version_test/ stays on
Shopify/sarama v1.38.1 by design. That older version omits
max_timestamp on produce batches, and SaramaLegacyProduceTest
relies on that omission to exercise the kafka_produce_batch_validation
code path. Bumping it would silently no-op the test.

franz-go: v1.15.1 → v1.20.7 in transform-verifier

Bumps tests/go/transform-verifier/go.mod from v1.15.1 to v1.20.7.
go mod tidy raised the Go directive 1.21.1 → 1.24.0 to match the
toolchain.

Fixes CORE-16243
& CORE-16244.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v26.1.x
  • v25.3.x
  • v25.2.x

Release Notes

  • none

@nguyen-andrew
Copy link
Copy Markdown
Member Author

/ci-repeat 1

Aligns the two IBM/sarama pin sites in the test infra:

  - tests/go/sarama/produce_test/go.mod (the produce_test binary)
  - tests/docker/ducktape-deps/sarama-examples (clone-and-build
    script for the example binaries used by SaramaTest)

These must move together: SaramaTest and SaramaProduceTest exercise
the same Sarama codebase via different harnesses, so skew between
the pins risks silent compat-coverage gaps.

The sibling produce_legacy_version_test/ stays on Shopify/sarama
v1.38.1 by design. That older version omits max_timestamp on produce
batches, and SaramaLegacyProduceTest relies on that omission to
exercise the kafka_produce_batch_validation code path.
@nguyen-andrew
Copy link
Copy Markdown
Member Author

Force push to rebase on dev.

Aligns with kgo-verifier's franz-go/kadm/kmsg pinning at v1.20.x,
v1.17.1, and v1.12.0 respectively. go mod tidy raised the Go directive
1.21.1 → 1.24.0 to match the toolchain (also matching kgo-verifier).
@nguyen-andrew nguyen-andrew changed the title dt/tests: bump IBM/sarama to v1.48.0 dt/tests: bump IBM/sarama and franz-go for Kafka 4.x test alignment May 13, 2026
@nguyen-andrew
Copy link
Copy Markdown
Member Author

/ci-repeat 1

@nguyen-andrew nguyen-andrew self-assigned this May 14, 2026
@nguyen-andrew nguyen-andrew marked this pull request as ready for review May 14, 2026 20:34
@nguyen-andrew nguyen-andrew requested a review from a team as a code owner May 14, 2026 20:34
@nguyen-andrew nguyen-andrew requested review from a team, Copilot, ivotron and pgellert and removed request for a team May 14, 2026 20:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Go-based test clients used in Redpanda’s dt/ducktape test environment to versions aligned with Kafka 4.x compatibility testing (ENG-1185), including corresponding module/sum updates.

Changes:

  • Bump github.com/twmb/franz-go (and related indirect deps) for transform-verifier, and update its go.mod Go version directive.
  • Bump github.com/IBM/sarama for the produce_test Go module.
  • Update the ducktape docker dependency script to clone/build Sarama examples from the matching Sarama tag.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tests/go/transform-verifier/go.mod Updates Go module directive and bumps franz-go + related dependencies used by transform-verifier.
tests/go/transform-verifier/go.sum Refreshes dependency checksums to match the updated transform-verifier module graph.
tests/go/sarama/produce_test/go.mod Bumps the Sarama dependency version for the Sarama-based produce test client.
tests/docker/ducktape-deps/sarama-examples Updates the Sarama git tag used to build example binaries in the ducktape deps image.

Copy link
Copy Markdown
Member

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming ducktape tests are green. so no backport required?

@nguyen-andrew
Copy link
Copy Markdown
Member Author

@ivotron I don't think we need to backport this

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

CI test results

test results on build#84483
test_status test_class test_method test_arguments test_kind job_url passed reason test_history
FLAKY(PASS) ShadowLinkBasicTests test_link_creation_checks {"source_cluster_spec": {"cluster_type": "kafka", "kafka_quorum": "COMBINED_KRAFT", "kafka_version": "3.8.0"}} integration https://buildkite.com/redpanda/redpanda/builds/84483#019e2839-d149-4e00-bf7c-4a45f191d854 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0342, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShadowLinkBasicTests&test_method=test_link_creation_checks
FLAKY(PASS) ClusterQuotaPartitionMutationTest test_partition_throttle_mechanism null integration https://buildkite.com/redpanda/redpanda/builds/84483#019e2839-d148-4797-b1da-c6ea76af0540 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0038, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ClusterQuotaPartitionMutationTest&test_method=test_partition_throttle_mechanism
FAIL SchemaScaleTest schema_scale_test {"catalog_type": "rest_hadoop", "cloud_storage_type": 1, "query_engine": "spark", "use_partition_spec": false} integration https://buildkite.com/redpanda/redpanda/builds/84483#019e2839-d145-4859-8e86-d49408001f02 0/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0007, p0=0.0000, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=SchemaScaleTest&test_method=schema_scale_test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants