Revert "bazel/wasm: upgrade wasmtime from 32.0.0 to 42.0.2"#30387
Merged
dotnwat merged 1 commit intoredpanda-data:devfrom May 6, 2026
Merged
Revert "bazel/wasm: upgrade wasmtime from 32.0.0 to 42.0.2"#30387dotnwat merged 1 commit intoredpanda-data:devfrom
dotnwat merged 1 commit intoredpanda-data:devfrom
Conversation
…rmetic-wasmtime42" This reverts merge commit bf92d38, reversing changes made to 3e9b64e. The wasmtime 42 upgrade breaks LTO builds. //tools:pgo_profile fails to link with: ld.lld: error: undefined symbol: __rustc::__rust_no_alloc_shim_is_unstable_v2 The mangled __rustc::* allocator shim symbols introduced in rustc 1.87+ (opted into via experimental_use_allocator_libraries_with_mangled_symbols in rules_rust) are not resolved correctly under LTO. Reverting until a proper fix is in place.
dotnwat
approved these changes
May 6, 2026
Collaborator
CI test resultstest results on build#84103
|
7 tasks
travisdowns
added a commit
that referenced
this pull request
May 7, 2026
Re-land of 08fc3c5, which was reverted in 6116d3a (PR #30387) because the upgrade broke the `--config=lto` / `--config=pgo-instrument` link with: ld.lld: error: undefined symbol: __rustc::__rust_no_alloc_shim_is_unstable_v2 That LTO failure is fixed by the preceding commit switching the rust LTO mode from fat to thin; this commit re-introduces the upgrade unchanged. Additional changes required by the upgrade: - Bump Rust toolchain from 1.86.0 to 1.91.0 (wasmtime 42 MSRV) - Add PULLEY and ALL_ARCH feature flags to wasmtime.BUILD conf.h template substitutions (new in wasmtime 42) - Remove wasmtime_config_async_support_set() call: async support is now implicit, the separate toggle was deprecated and removed from the C API (bytecodealliance/wasmtime#12371) - Bump rules_rust 0.60.0 -> 0.70.0 and opt in to experimental_use_allocator_libraries_with_mangled_symbols so the mangled __rustc::* allocator shim symbols (introduced in rustc 1.87+) are provided when a Rust staticlib is linked into a cc_binary via cc_common.link. Without this flag the link fails with undefined references to __rustc::__rust_alloc, __rustc::__rust_dealloc, etc. Background: - Issue: bazelbuild/rules_rust#3459 - Fix PR: bazelbuild/rules_rust#3403 - Landed in rules_rust 0.63.0 as an opt-in setting. - Mirror the rustc tarball through vectorized-public to reduce dependence on static.rust-lang.org. - Incidental: bump bazel_skylib 1.8.1 -> 1.8.2 and rules_shell 0.4.1 -> 0.6.1 to silence direct-dependency version warnings pulled in by the new rules_rust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #30263.
The wasmtime 42 upgrade breaks LTO builds.
//tools:pgo_profilefailsto link with:
The mangled
__rustc::*allocator shim symbols introduced in rustc1.87+ (opted into via
experimental_use_allocator_libraries_with_mangled_symbolsin rules_rust) are not resolved correctly under LTO. Reverting until a
proper fix is in place; will re-land once the LTO interaction is sorted
out.
Backports Required
Release Notes