Skip to content

dt: export cluster config even if there are bad loglines#28506

Merged
IoannisRP merged 1 commit into
redpanda-data:devfrom
IoannisRP:ik-dt-export-cluster-config
Nov 14, 2025
Merged

dt: export cluster config even if there are bad loglines#28506
IoannisRP merged 1 commit into
redpanda-data:devfrom
IoannisRP:ik-dt-export-cluster-config

Conversation

@IoannisRP
Copy link
Copy Markdown
Contributor

Move export config before check for bad loglines.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v25.3.x
  • v25.2.x
  • v25.1.x
  • v24.3.x

Release Notes

  • none

@IoannisRP IoannisRP requested review from a team and travisdowns November 13, 2025 11:14
@IoannisRP IoannisRP self-assigned this Nov 13, 2025
@IoannisRP IoannisRP requested review from Copilot and michael-redpanda and removed request for a team November 13, 2025 11:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the order of operations in the post-test checks to ensure cluster configuration export happens even when bad log lines are detected. The change moves the export_cluster_config() call to execute before the log inspection checks, which can raise exceptions and prevent the export from occurring.

Key changes:

  • Reordered export_cluster_config() to execute earlier in the test cleanup flow, before potential error log validation failures

@IoannisRP IoannisRP enabled auto-merge November 13, 2025 11:14
@vbotbuildovich
Copy link
Copy Markdown
Collaborator

vbotbuildovich commented Nov 13, 2025

Retry command for Build#76198

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/audit_log_test.py::AuditLogTestInvalidConfigMTLS.test_invalid_config_mtls@{"audit_transport_mode":"kclient"}
tests/rptest/tests/audit_log_test.py::AuditLogTestInvalidConfig.test_invalid_config@{"audit_transport_mode":"kclient"}

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

vbotbuildovich commented Nov 13, 2025

CI test results

test results on build#76198
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
AuditLogTestInvalidConfig test_invalid_config {"audit_transport_mode": "kclient"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7cfe-f089-4799-b7a0-4b3de6ffdb04 FAIL 0/21 The test has failed across all retries https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=AuditLogTestInvalidConfig&test_method=test_invalid_config
AuditLogTestInvalidConfig test_invalid_config {"audit_transport_mode": "kclient"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7d06-56e6-4407-b66c-057587bfa009 FAIL 0/21 The test has failed across all retries https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=AuditLogTestInvalidConfig&test_method=test_invalid_config
AuditLogTestInvalidConfigMTLS test_invalid_config_mtls {"audit_transport_mode": "kclient"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7cfe-f08b-4c6b-a824-fc7a1091815c FAIL 0/21 The test has failed across all retries https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=AuditLogTestInvalidConfigMTLS&test_method=test_invalid_config_mtls
AuditLogTestInvalidConfigMTLS test_invalid_config_mtls {"audit_transport_mode": "kclient"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7d06-56e8-4b5c-b557-97f0a3911f83 FAIL 0/21 The test has failed across all retries https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=AuditLogTestInvalidConfigMTLS&test_method=test_invalid_config_mtls
AuditLogTestKafkaApi test_no_auth_enabled {"audit_transport_mode": "kclient"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7d06-56e6-4407-b66c-057587bfa009 FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=AuditLogTestKafkaApi&test_method=test_no_auth_enabled
ShadowLinkingReplicationTests test_replication_basic {"shuffle_leadership": true, "source_cluster_spec": {"cluster_type": "redpanda"}} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7cfe-f085-4117-931d-8cc032309bd5 FLAKY 16/21 upstream reliability is '88.125'. current run reliability is '76.19047619047619'. drift is 11.93452 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShadowLinkingReplicationTests&test_method=test_replication_basic
ShadowLinkingReplicationTests test_replication_basic {"shuffle_leadership": true, "source_cluster_spec": {"cluster_type": "redpanda"}} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7d06-56e5-4c21-b659-3975c53de48d FLAKY 16/21 upstream reliability is '88.125'. current run reliability is '76.19047619047619'. drift is 11.93452 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShadowLinkingReplicationTests&test_method=test_replication_basic
JavaCompressionTest test_upgrade_java_compression {"compression_type": "gzip"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7cfe-f089-4799-b7a0-4b3de6ffdb04 FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=JavaCompressionTest&test_method=test_upgrade_java_compression
JavaCompressionTest test_upgrade_java_compression {"compression_type": "gzip"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7d06-56e6-4407-b66c-057587bfa009 FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=JavaCompressionTest&test_method=test_upgrade_java_compression
JavaCompressionTest test_upgrade_java_compression {"compression_type": "lz4"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7cfe-f08a-4378-b890-c0378f0314ad FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=JavaCompressionTest&test_method=test_upgrade_java_compression
JavaCompressionTest test_upgrade_java_compression {"compression_type": "lz4"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7d06-56e7-4ac2-9279-4f95f6572443 FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=JavaCompressionTest&test_method=test_upgrade_java_compression
JavaCompressionTest test_upgrade_java_compression {"compression_type": "snappy"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7cfe-f08b-4c6b-a824-fc7a1091815c FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=JavaCompressionTest&test_method=test_upgrade_java_compression
JavaCompressionTest test_upgrade_java_compression {"compression_type": "snappy"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7d06-56e8-4b5c-b557-97f0a3911f83 FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=JavaCompressionTest&test_method=test_upgrade_java_compression
JavaCompressionTest test_upgrade_java_compression {"compression_type": "zstd"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7cfe-f08d-4e7d-b133-f269e7e2f8ee FLAKY 20/21 upstream reliability is '99.77220956719817'. current run reliability is '95.23809523809523'. drift is 4.53411 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=JavaCompressionTest&test_method=test_upgrade_java_compression
JavaCompressionTest test_upgrade_java_compression {"compression_type": "zstd"} integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7d06-56e9-4030-918c-a06d1a5ee64d FLAKY 20/21 upstream reliability is '99.77220956719817'. current run reliability is '95.23809523809523'. drift is 4.53411 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=JavaCompressionTest&test_method=test_upgrade_java_compression
DataMigrationsApiTest test_creating_and_listing_migrations null integration https://buildkite.com/redpanda/redpanda/builds/76198#019a7cfe-f079-4677-afa6-a31f5145b23b FLAKY 20/21 upstream reliability is '98.90664423885617'. current run reliability is '95.23809523809523'. drift is 3.66855 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DataMigrationsApiTest&test_method=test_creating_and_listing_migrations
test results on build#76224
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
MountUnmountIcebergTest test_simple_remount {"cloud_storage_type": 1} integration https://buildkite.com/redpanda/redpanda/builds/76224#019a7e2b-b567-4aee-b206-6a81c36ca353 FLAKY 16/21 upstream reliability is '85.02127659574468'. current run reliability is '76.19047619047619'. drift is 8.8308 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=MountUnmountIcebergTest&test_method=test_simple_remount
test results on build#76240
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
ShadowLinkingReplicationTests test_replication_with_failures null integration https://buildkite.com/redpanda/redpanda/builds/76240#019a7eab-c84c-481e-ae5e-18ef4072ddf6 FLAKY 19/21 upstream reliability is '96.04130808950086'. current run reliability is '90.47619047619048'. drift is 5.56512 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShadowLinkingReplicationTests&test_method=test_replication_with_failures
PartitionMovementUpgradeTest test_basic_upgrade null integration https://buildkite.com/redpanda/redpanda/builds/76240#019a7eab-c84d-4339-b405-64bf497866f2 FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=PartitionMovementUpgradeTest&test_method=test_basic_upgrade
TieredStorageTest test_tiered_storage {"cloud_storage_type_and_url_style": [1, "path"], "test_case": {"name": "(TS_Read == True, TS_Timequery == True)"}} integration https://buildkite.com/redpanda/redpanda/builds/76240#019a7eab-c84c-481e-ae5e-18ef4072ddf6 FLAKY 20/21 upstream reliability is '99.5505617977528'. current run reliability is '95.23809523809523'. drift is 4.31247 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=TieredStorageTest&test_method=test_tiered_storage

@IoannisRP
Copy link
Copy Markdown
Contributor Author

changes in force-push:

  • update "mis-configured audit log" tests to accept the nagging that comes from printing the config without properly configured audit logging.

@IoannisRP IoannisRP merged commit dcce259 into redpanda-data:dev Nov 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants