dev_cluster: remove grafana/prom logging#28499
Merged
Merged
Conversation
This is just noise and not useful, if we really need it, it's in the log file.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes logging output from Prometheus and Grafana processes in the development cluster tooling. The change simplifies the code by eliminating stdout/stderr capture and the associated line-by-line printing loop for both services.
Key Changes:
- Redirects Prometheus and Grafana process output to DEVNULL instead of capturing it
- Removes the async reading loops that printed each line of output
nvartolomei
approved these changes
Nov 13, 2025
Contributor
nvartolomei
left a comment
nvartolomei
left a comment
There was a problem hiding this comment.
don't have a horse in this race so trusting your decision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just noise and not useful, if we really need it, it's in the log file.
Backports Required
Release Notes