Skip to content

rptest: Enable fast uploads in datalake test#28492

Merged
Lazin merged 1 commit into
redpanda-data:devfrom
Lazin:fix/delayed-translation-test-fix
Nov 12, 2025
Merged

rptest: Enable fast uploads in datalake test#28492
Lazin merged 1 commit into
redpanda-data:devfrom
Lazin:fix/delayed-translation-test-fix

Conversation

@Lazin
Copy link
Copy Markdown
Contributor

@Lazin Lazin commented Nov 12, 2025

The test expects uplads to happen in 10 minutes. The problem is that it create different number of partitions in docker and on a dedicated machine (100 vs 1000). With 1000 partitions the chance that one partition will receive not enough data to roll a segment is relatively high.

The fix is to force uploads and to increase the amount of data on a dedicated node.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v25.3.x
  • v25.2.x
  • v25.1.x
  • v24.3.x

Release Notes

  • none

The test expects uplads to happen in 10 minutes. The problem is that it
create different number of partitions in docker and on a dedicated
machine (100 vs 1000). With 1000 partitions the chance that one
partition will receive not enough data to roll a segment is relatively
high.

The fix is to force uploads and to increase the amount of data on a
dedicated node.

Signed-off-by: Evgeny Lazin <[email protected]>
@Lazin Lazin requested review from bashtanov and Copilot November 12, 2025 15:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a timing issue in the datalake delayed translation test where uploads were not completing within the expected 10-minute window. The root cause was that the test creates different numbers of partitions (100 vs 1000) depending on whether it runs in Docker or on dedicated machines, leading to insufficient data per partition to trigger segment rolls on dedicated nodes.

Key changes:

  • Enables fast uploads to ensure timely completion of data uploads
  • Increases data volume on dedicated nodes to guarantee segment rolls across all partitions

self.TOPIC_NAME,
self.SCHEMA_NAME,
{"weight": "range(0, 10000)"},
{"weight": f"range(0, {count})"},
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of an f-string to construct a range string (e.g., 'range(0, 50000)') suggests this is being passed as a string to be evaluated elsewhere. Consider whether passing the actual count value directly would be clearer and safer than constructing a string representation of Python code.

Suggested change
{"weight": f"range(0, {count})"},
{"weight": count},

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@bashtanov bashtanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
there's a typo in the commit message: "uplads"

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

CI test results

test results on build#76122
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
ShadowLinkingReplicationTests test_replication_basic {"shuffle_leadership": true, "source_cluster_spec": {"cluster_type": "redpanda"}} integration https://buildkite.com/redpanda/redpanda/builds/76122#019a78ab-9078-4689-8c6b-8301c1532820 FLAKY 16/21 upstream reliability is '88.75816993464052'. current run reliability is '76.19047619047619'. drift is 12.56769 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShadowLinkingReplicationTests&test_method=test_replication_basic

@Lazin Lazin merged commit 770cd68 into redpanda-data:dev Nov 12, 2025
18 checks passed
@vbotbuildovich
Copy link
Copy Markdown
Collaborator

/backport v25.3.x

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

/backport v25.2.x

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

Branch name "v25.3.x" not found.

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants