Add early return logging to timequeries#28485
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds debug logging to the timequery function to help diagnose a test flake where timequeries against cloud storage occasionally return incorrect empty results. The logging captures key state information at function entry and at early return points where nullopt is returned.
Key Changes:
- Added entry-point logging to capture timequery configuration and partition state
- Added logging at two early return points where the function returns
nulloptdue to offset range violations
| vlog( | ||
| clusterlog.debug, | ||
| "[{}] timequery: early return (nullopt) at line 658 - " | ||
| "[{}] timequery: early return (nullopt) - " |
There was a problem hiding this comment.
Hmmm mind squashing these? not sure if we have a policy for this, but it seems undesirable to leave them in (e.g. they'll be in git history which is kind of distracting when code spelunking)
andrwng
left a comment
There was a problem hiding this comment.
Ideally, we can remove or pare down the logging once the issue is resolved.
If you're thinking we don't want these long term, you can try running ci-repeat commands on this PR to repeat the specific test that runs into the issue. Then we can get to the bottom of it without merging these lines to dev
CI test resultstest results on build#76078
test results on build#76167
test results on build#76235
|
9c7237b to
1b5e506
Compare
1b5e506 to
22e7be2
Compare
|
Force push to squash. Forgot to rebase and it pulled in a bunch of old commits. If you're here because you got a random review request please ignore, sorry. |
|
/ci-repeat 10 |
|
/ci-repeat 5 |
1 similar comment
|
/ci-repeat 5 |
|
/ci-repeat 10 |
|
Never got this logging to pay off but I was able to figure out the source of the bug. See #28642 |
There's a test flake where timequeries against cloud storage sometimes return nothing incorrectly. This extra logging will help pinpoint how this is happening.
Ideally, we can remove or pare down the logging once the issue is resolved.
Backports Required
Release Notes