Skip to content

[v25.1.x] CORE-13747: Add RedpandaRoles to Whole Cluster Recovery#28268

Merged
nguyen-andrew merged 6 commits into
redpanda-data:v25.1.xfrom
nguyen-andrew:manual-backport-28166-v25.1.x-420
Nov 12, 2025
Merged

[v25.1.x] CORE-13747: Add RedpandaRoles to Whole Cluster Recovery#28268
nguyen-andrew merged 6 commits into
redpanda-data:v25.1.xfrom
nguyen-andrew:manual-backport-28166-v25.1.x-420

Conversation

@nguyen-andrew
Copy link
Copy Markdown
Member

@nguyen-andrew nguyen-andrew commented Oct 29, 2025

Backport of PR #28166

Closes #28255

@nguyen-andrew nguyen-andrew added this to the v25.1.x-next milestone Oct 29, 2025
@nguyen-andrew nguyen-andrew added the kind/backport PRs targeting a stable branch label Oct 29, 2025
@nguyen-andrew
Copy link
Copy Markdown
Member Author

/ci-repeat 1

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

vbotbuildovich commented Oct 30, 2025

Retry command for Build#75260

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/redpanda_oauth_test.py::RedpandaOIDCTlsTest.test_admin_invalidate_keys
tests/rptest/tests/redpanda_oauth_test.py::RedpandaOIDCTlsTest.test_admin_whoami
tests/rptest/tests/redpanda_oauth_test.py::RedpandaOIDCTlsTest.test_admin_revoke

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

vbotbuildovich commented Oct 30, 2025

CI test results

test results on build#75260
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
RandomNodeOperationsTest test_node_operations {"cloud_storage_type": 1, "enable_failures": true, "mixed_versions": false, "with_chunked_compaction": true, "with_iceberg": true, "with_tiered_storage": false} integration https://buildkite.com/redpanda/redpanda/builds/75260#019a3271-58f7-463f-9ab6-6430e6b0046c FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RandomNodeOperationsTest&test_method=test_node_operations
RedpandaKerberosConfigTest test_non_default null integration https://buildkite.com/redpanda/redpanda/builds/75260#019a326e-7c14-48c4-9120-41aa79ea829c FLAKY 19/21 upstream reliability is '100.0'. current run reliability is '90.47619047619048'. drift is 9.52381 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaKerberosConfigTest&test_method=test_non_default
RedpandaOIDCTlsTest test_admin_invalidate_keys null integration https://buildkite.com/redpanda/redpanda/builds/75260#019a326e-7c13-4dd9-8a0d-f4616eef107f FAIL 0/21 The test has failed across all retries https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaOIDCTlsTest&test_method=test_admin_invalidate_keys
RedpandaOIDCTlsTest test_admin_revoke null integration https://buildkite.com/redpanda/redpanda/builds/75260#019a326e-7c14-48c4-9120-41aa79ea829c FLAKY 8/21 upstream reliability is '100.0'. current run reliability is '38.095238095238095'. drift is 61.90476 and the allowed drift is set to 50. The test should FAIL https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaOIDCTlsTest&test_method=test_admin_revoke
RedpandaOIDCTlsTest test_admin_whoami null integration https://buildkite.com/redpanda/redpanda/builds/75260#019a326e-7c15-403c-9b9e-16002cfbd434 FAIL 0/21 The test has failed across all retries https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaOIDCTlsTest&test_method=test_admin_whoami
WriteCachingFailureInjectionE2ETest test_crash_all_with_consumer_group null integration https://buildkite.com/redpanda/redpanda/builds/75260#019a326e-7c19-43be-9384-c8ff9263aaef FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=WriteCachingFailureInjectionE2ETest&test_method=test_crash_all_with_consumer_group
test results on build#75336
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
RedpandaOIDCTlsTest test_admin_invalidate_keys null integration https://buildkite.com/redpanda/redpanda/builds/75336#019a3645-b612-459a-bf91-59d8819d1a80 FAIL 0/21 The test has failed across all retries https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaOIDCTlsTest&test_method=test_admin_invalidate_keys
RedpandaOIDCTlsTest test_admin_revoke null integration https://buildkite.com/redpanda/redpanda/builds/75336#019a3645-b612-459a-bf91-59d8819d1a80 FLAKY 9/21 upstream reliability is '100.0'. current run reliability is '42.857142857142854'. drift is 57.14286 and the allowed drift is set to 50. The test should FAIL https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaOIDCTlsTest&test_method=test_admin_revoke
RedpandaOIDCTlsTest test_admin_whoami null integration https://buildkite.com/redpanda/redpanda/builds/75336#019a3645-b612-459a-bf91-59d8819d1a80 FLAKY 1/21 upstream reliability is '100.0'. current run reliability is '4.761904761904762'. drift is 95.2381 and the allowed drift is set to 50. The test should FAIL https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaOIDCTlsTest&test_method=test_admin_whoami
test results on build#76019
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
RandomNodeOperationsTest test_node_operations {"cloud_storage_type": 1, "enable_failures": true, "mixed_versions": false, "with_chunked_compaction": false, "with_iceberg": true, "with_tiered_storage": true} integration https://buildkite.com/redpanda/redpanda/builds/76019#019a73a7-e3c7-4ca0-b7ea-5f5d055e5120 FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RandomNodeOperationsTest&test_method=test_node_operations
test results on build#76083
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
PartitionBalancerTest test_fuzz_admin_ops null integration https://buildkite.com/redpanda/redpanda/builds/76083#019a7682-986f-4e7f-b678-0097c6dca951 FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=PartitionBalancerTest&test_method=test_fuzz_admin_ops
SaslPlainTest test_plain_authn {"client_type": 4, "sasl_plain_enabled": false, "scram_type": 1} integration https://buildkite.com/redpanda/redpanda/builds/76083#019a7682-986d-43a1-b27f-788f16f5dc6b FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=SaslPlainTest&test_method=test_plain_authn
test results on build#76142
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
DeleteRecordsTest test_delete_records_concurrent_truncations {"cloud_storage_enabled": true, "truncate_point": "random_offset"} integration https://buildkite.com/redpanda/redpanda/builds/76142#019a7961-4602-452d-bb35-aabd83a50e53 FLAKY 16/21 upstream reliability is '84.21052631578947'. current run reliability is '76.19047619047619'. drift is 8.02005 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DeleteRecordsTest&test_method=test_delete_records_concurrent_truncations

@nguyen-andrew
Copy link
Copy Markdown
Member Author

/ci-repeat 1
tests/rptest/tests/redpanda_oauth_test.py::RedpandaOIDCTlsTest.test_admin_invalidate_keys
tests/rptest/tests/redpanda_oauth_test.py::RedpandaOIDCTlsTest.test_admin_whoami
tests/rptest/tests/redpanda_oauth_test.py::RedpandaOIDCTlsTest.test_admin_revoke

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

Retry command for Build#75336

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/redpanda_oauth_test.py::RedpandaOIDCTlsTest.test_admin_whoami
tests/rptest/tests/redpanda_oauth_test.py::RedpandaOIDCTlsTest.test_admin_invalidate_keys
tests/rptest/tests/redpanda_oauth_test.py::RedpandaOIDCTlsTest.test_admin_revoke

Updating controller_snapshot_reconciler::get_actions to extract
role actions from security snapshot, and then updating the
cluster_recovery_backend to apply the role actions to the
security_frontend. This role recovery will be bundled in with
the ACL recovery stage in order to avoid adding a new recovery
stage enum that would prevent backportablity.

(cherry picked from commit 1746897)
Extending the existing snapshot reconciliation and cluster recovery
unit tests to exercise role recovery.

(cherry picked from commit 753ef2c)
@nguyen-andrew nguyen-andrew force-pushed the manual-backport-28166-v25.1.x-420 branch from 23c4710 to 74c8998 Compare November 11, 2025 14:24
@nguyen-andrew
Copy link
Copy Markdown
Member Author

Force pushed to get latest v25.1.x and get the fix from #28451

@nguyen-andrew
Copy link
Copy Markdown
Member Author

/ci-repeat 1

@nguyen-andrew nguyen-andrew self-assigned this Nov 11, 2025
@nguyen-andrew nguyen-andrew marked this pull request as ready for review November 11, 2025 14:53
@nguyen-andrew nguyen-andrew force-pushed the manual-backport-28166-v25.1.x-420 branch from 74c8998 to 4c05da6 Compare November 12, 2025 04:00
@nguyen-andrew
Copy link
Copy Markdown
Member Author

Force pushed to add missing functions and classes in rpk.py that haven't been backported yet.

@nguyen-andrew nguyen-andrew requested review from a team and pgellert and removed request for a team November 12, 2025 14:44
Backporting one of the updates made to rpk.py in the following commit:
redpanda-data@a273f54
Backporting updates made to rpk.py in the following commit:
redpanda-data@0b0f73a
…k.py

Removing fields that aren't available to rpk until 25.2.
Extending the test_basic_controller_snapshot_restore ducktape test
to validate the restoration of roles.

(cherry picked from commit 7b9eaba)
@nguyen-andrew nguyen-andrew force-pushed the manual-backport-28166-v25.1.x-420 branch from 4c05da6 to a387556 Compare November 12, 2025 17:34
@nguyen-andrew
Copy link
Copy Markdown
Member Author

nguyen-andrew commented Nov 12, 2025

Force pushed to restructure commits and better separate partial rpk.py backport to help with future archaeology. Also removed inapplicable fields to backport of rpk.py

@nguyen-andrew nguyen-andrew merged commit abdb727 into redpanda-data:v25.1.x Nov 12, 2025
17 checks passed
@nguyen-andrew nguyen-andrew deleted the manual-backport-28166-v25.1.x-420 branch November 12, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/redpanda kind/backport PRs targeting a stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants