Port 1-084_validate_prune_templates to Ginko#1089
Merged
openshift-merge-bot[bot] merged 2 commits intoredhat-developer:masterfrom Apr 7, 2026
Conversation
trdoyle81
force-pushed
the
GTIOPS-7206-1-084-Port_validate_prune_templates-to-ginko
branch
from
97ca9ab to
e001cf0
Compare
Member
Author
|
/retest |
Member
Author
|
/retest-required |
trdoyle81
force-pushed
the
GTIOPS-7206-1-084-Port_validate_prune_templates-to-ginko
branch
2 times, most recently
from
1d19949 to
ac9d0ad
Compare
varshab1210
reviewed
Mar 12, 2026
| app.SetNamespace("openshift-gitops") | ||
|
|
||
| // application spec | ||
| Expect(unstructured.SetNestedField(app.Object, "default", "spec", "project")).To(Succeed()) |
Member
There was a problem hiding this comment.
Are there any challenges you see in adding the app spec using the schema?
Member
Author
There was a problem hiding this comment.
Thanks for the suggestion. I've changed to use the struct from the argoproj schema for CR creation so it's the same as the 1-120 test.
trdoyle81
force-pushed
the
GTIOPS-7206-1-084-Port_validate_prune_templates-to-ginko
branch
from
f53cd44 to
804715c
Compare
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
trdoyle81
force-pushed
the
GTIOPS-7206-1-084-Port_validate_prune_templates-to-ginko
branch
from
804715c to
6d7f824
Compare
Member
|
/lgtm |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varshab1210 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/test v4.19-kuttl-sequential |
trdoyle81
force-pushed
the
GTIOPS-7206-1-084-Port_validate_prune_templates-to-ginko
branch
from
6d7f824 to
dd1e331
Compare
Member
Author
|
/retest |
2 similar comments
Member
Author
|
/retest |
Member
Author
|
/retest |
added 2 commits
April 7, 2026 08:20
Signed-off-by: Triona Doyle <bot@example.com>
Signed-off-by: Triona Doyle <bot@example.com>
trdoyle81
force-pushed
the
GTIOPS-7206-1-084-Port_validate_prune_templates-to-ginko
branch
from
dd1e331 to
1481480
Compare
Member
|
/lgtm |
openshift-merge-bot
Bot
merged commit 9ee56b4
into
redhat-developer:master
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
Porting test from Kuttl to Ginko. The test validates that Argo CD correctly prunes resources with duplicate GroupVersionKinds (GVKs) when executing a sync via the Argo CD CLI
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #GITOPS-7206
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
export GINKGO_TEST_SUITE="sequential"
export GINKGO_TEST="1-084_validate_prune_templates"
./bin/ginkgo -v -focus $GINKGO_TEST -r ./test/openshift/e2e/ginkgo/$GINKGO_TEST_SUITE