Skip to content

fix: infra-openshift-cnv-resources network config not valid JSON #9776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prakhar1985 wants to merge 2 commits into
base: development
Choose a base branch
from
Open

fix: infra-openshift-cnv-resources network config not valid JSON #9776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f37af7
fix: convert network config from Python dict string to YAML dict
Apr 16, 2026
f1f9bee
fix: use 'is defined' instead of string boolean in create_inventory
Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansible/roles-infra/infra-openshift-cnv-create-inventory/tasks/create_inventory.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
sessionAffinity: None
type: NodePort
register: r_expose_bastion
when: local_bastion|default(False)
when: local_bastion is defined
until: r_expose_bastion is success
retries: "{{ openshift_cnv_retries }}"
delay: "{{ openshift_cnv_delay }}"
Expand Down
8 changes: 7 additions & 1 deletion ansible/roles-infra/infra-openshift-cnv-resources/tasks/create_network.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,13 @@
spec:
config: "{{ config | to_json }}"
vars:
config: "{'cniVersion':'0.3.1','type':'ovn-k8s-cni-overlay','topology':'layer2','name': '{{ _network.name }}{{ guid }}', 'netAttachDefName': '{{ openshift_cnv_namespace }}/{{ _network.name }}{{ guid }}', 'mtu': {{ _network.mtu | default(1500) }}}"
config:
cniVersion: "0.3.1"
type: "ovn-k8s-cni-overlay"
topology: "layer2"
name: "{{ _network.name }}{{ guid }}"
netAttachDefName: "{{ openshift_cnv_namespace }}/{{ _network.name }}{{ guid }}"
mtu: "{{ _network.mtu | default(1500) | int }}"
register: r_createnetwork
until: r_createnetwork is success
retries: "{{ openshift_cnv_retries }}"
Expand Down
Loading