Fix workload ocp4_workload_nvidia_gpu_setup configs: snapshot, install_plan_approval#9721
Open
ryanj wants to merge 2 commits intoredhat-cop:developmentfrom
Open
Fix workload ocp4_workload_nvidia_gpu_setup configs: snapshot, install_plan_approval#9721ryanj wants to merge 2 commits intoredhat-cop:developmentfrom
ryanj wants to merge 2 commits intoredhat-cop:developmentfrom
Conversation
7e893c7 to
9e4d9e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing workload
roles_ocp_workloads/ocp4_workload_nvidia_gpu_setup:nvidia_gpu_operator_use_catalog_snapshothas a default value offalse. This change will allow the nvidia operator subscription to be loaded via a custom CatalogSource when the config is reset totruenvidia_gpu_operator_automatic_install_plan_approvalhas a default value oftrue. This change allows the operator to function inManualapproval mode when the input is set tofalse, which will inhibit thenvidia_gpu_operator_starting_csvfrom automatically rolling forward to the latest available release.SUMMARY
I noticed that the
ocp4_workload_nvidia_gpu_setupworkload defines configuration defaults fornvidia_gpu_operator_use_catalog_snapshot, andnvidia_gpu_operator_automatic_install_plan_approval, but the code for these configs was never implemented.This change allows for more control over the installation of this operator (without changing the default behavior).
ISSUE TYPE
COMPONENT NAME
roles_ocp_workloads/ocp4_workload_nvidia_gpu_setupADDITIONAL INFORMATION
Not urgent