Add a (simple) PDF profile #97
Merged
Merged
Conversation
HadrienGardeur
left a comment
HadrienGardeur
left a comment
Member
There was a problem hiding this comment.
Not much to say overall, just minor tweaks.
|
|
||
| ## Introduction | ||
|
|
||
| The goal of this specification is to provide a profile of the [Readium Web Publication Manifest](https://readium.org/webpub-manifest) dedicated to pdf documents. |
Member
There was a problem hiding this comment.
Should be "PDF documents" instead of lowercase pdf.
| This profile relies on: | ||
|
|
||
| * a declaration of [conformance with this Profile](#1-declaring-conformance-with-the-pdf-profile), | ||
| * some [restrictions on the resources of the reading order](#2-restrictions-on-the-resources-of-the-reading-order), |
Member
There was a problem hiding this comment.
It's a single restriction currently.
|
|
||
| ## 1. Declaring conformance with the PDF Profile | ||
|
|
||
| To declare that it conforms to the PDF Profile, a Readium Web Publication Manifest <strong class="rfc">must</strong> include a `conformsTo` key in its `metadata` section, with `https://readium.org/webpub-manifest/profiles/pdf` as value. |
Member
There was a problem hiding this comment.
This should be modified to say "with https://readium.org/webpub-manifest/profiles/pdf as one of its values."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we need to have a PDF profile released asap, Here is a simple proposal, with a text aligned with the other profiles and no introduction of a new property, as in #88.
If we agree about the addition of a
startproperty (which means that every Readium toolkits will be ready to implement it), we'll update this profile accordingly.