Use of layout in profiles#120
Draft
HadrienGardeur wants to merge 2 commits into
Draft
Conversation
Smoothed some of the differences between EPUB and Divina
Member
Author
|
We'll need to revisit this PR now that we know that EPUB 3.4 will continue to support overrides per item in Now that Maybe:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're currently in the process of implementing
layoutas a top-level property in most of our toolkits. This is a good opportunity to review profiles and smooth things out between them.Tagging this one as a draft for now, until we've reviewed all profiles.