Optimize nested style array flattening#57200
Closed
tarikfp wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flatten nested style arrays directly into the final result object instead of recursively allocating intermediate flattened objects and copying their keys again.
This preserves the existing public behavior:
Nested style arrays can show up when style props are composed across component boundaries. Avoiding the intermediate object reduces allocation and duplicate key-copy work for those paths.
Local benchmark
Node v24.15.0 side-by-side microbenchmark, 9-run median, 5,000,000 iterations per run:
Changelog:
[GENERAL][CHANGED] - Improve flattening performance for nested style arrays.
Test Plan:
./node_modules/.bin/eslint --max-warnings 0 packages/react-native/Libraries/StyleSheet/flattenStyle.js packages/react-native/Libraries/StyleSheet/__tests__/flattenStyle-test.js packages/react-native/Libraries/StyleSheet/__tests__/flattenStyle-benchmark-itest.jsyarn jest packages/react-native/Libraries/StyleSheet/__tests__/flattenStyle-test.js --runInBandyarn flow checkgit diff --checkyarn fantom packages/react-native/Libraries/StyleSheet/__tests__/flattenStyle-benchmark-itest.js --benchmarksexits successfully in OSS, but the benchmark suite is skipped by the OSS Fantom optimized-mode gate.